Introduced in bug 98456, truncated-direct-png-image.html was introduced as a reftest, but it doesn't need to be. As a result it failed on mac (and has been suppressed).
Created attachment 168482 [details] Patch
You should set the review flag if you want this reviewed.
Comment on attachment 168482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review > LayoutTests/compositing/images/truncated-direct-png-image.html:21 > + document.getElementById('layers').innerText = window.internals.layerTreeAsText(document); textContent is the more modern innerText equivalent. :) > LayoutTests/compositing/images/truncated-direct-png-image.html:32 > +The layer tree goes here in DRT. Maybe this should say FAIL in it, as it would be a failure if the JS didn't run.
Created attachment 169494 [details] Patch
(In reply to comment #3) > (From update of attachment 168482 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review > > > LayoutTests/compositing/images/truncated-direct-png-image.html:21 > > + document.getElementById('layers').innerText = window.internals.layerTreeAsText(document); > > textContent is the more modern innerText equivalent. :) Fixed. > > > LayoutTests/compositing/images/truncated-direct-png-image.html:32 > > +The layer tree goes here in DRT. > > Maybe this should say FAIL in it, as it would be a failure if the JS didn't run. Fixed -- the "layer tree goes here" text now gets added in dynamically in the non-DRT case.
Comment on attachment 169494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169494&action=review Nick, none of the patches you posted run on the EWS as the Mac's TestExpectations didn't apply properly. Could you post a patch against WebKit trunk that would apply cleanly? This would give the CC'ed reviewers more confidence in your change. I cannot comment on the change as I don't know window.internals.layerTreeAsText output enough. > LayoutTests/compositing/images/truncated-direct-png-image.html:1 > <html> Usually we put a DOCTYPE to test to avoid having them run in quirks mode (something most people don't want).