Bug 99207 - truncated-direct-png-image.html should not be a reftest
Summary: truncated-direct-png-image.html should not be a reftest
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Carter
URL:
Keywords:
Depends on: 98456
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-12 14:05 PDT by Nick Carter
Modified: 2012-10-31 09:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2012-10-12 14:23 PDT, Nick Carter 		no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2012-10-18 15:54 PDT, Nick Carter 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Carter 2012-10-12 14:05:17 PDT 
Introduced in bug 98456, truncated-direct-png-image.html was introduced as a reftest, but it doesn't need to be. As a result it failed on mac (and has been suppressed).
Comment 1 Nick Carter 2012-10-12 14:23:48 PDT 
Created attachment 168482 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-10-12 14:26:21 PDT 
You should set the review flag if you want this reviewed.
Comment 3 Eric Seidel (no email) 2012-10-15 12:54:08 PDT 
Comment on attachment 168482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review

> LayoutTests/compositing/images/truncated-direct-png-image.html:21
> +      document.getElementById('layers').innerText = window.internals.layerTreeAsText(document);

textContent is the more modern innerText equivalent. :)

> LayoutTests/compositing/images/truncated-direct-png-image.html:32
> +The layer tree goes here in DRT.

Maybe this should say FAIL in it, as it would be a failure if the JS didn't run.
Comment 4 Nick Carter 2012-10-18 15:54:07 PDT 
Created attachment 169494 [details]
Patch
Comment 5 Nick Carter 2012-10-18 15:54:57 PDT 
(In reply to comment #3)
> (From update of attachment 168482 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review
> 
> > LayoutTests/compositing/images/truncated-direct-png-image.html:21
> > +      document.getElementById('layers').innerText = window.internals.layerTreeAsText(document);
> 
> textContent is the more modern innerText equivalent. :)

Fixed.

> 
> > LayoutTests/compositing/images/truncated-direct-png-image.html:32
> > +The layer tree goes here in DRT.
> 
> Maybe this should say FAIL in it, as it would be a failure if the JS didn't run.

Fixed -- the "layer tree goes here" text now gets added in dynamically in the non-DRT case.
Comment 6 Julien Chaffraix 2012-10-31 09:43:06 PDT 
Comment on attachment 169494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169494&action=review

Nick, none of the patches you posted run on the EWS as the Mac's TestExpectations didn't apply properly. Could you post a patch against WebKit trunk that would apply cleanly? This would give the CC'ed reviewers more confidence in your change. I cannot comment on the change as I don't know window.internals.layerTreeAsText output enough.

> LayoutTests/compositing/images/truncated-direct-png-image.html:1
>  <html>

Usually we put a DOCTYPE to test to avoid having them run in quirks mode (something most people don't want).