Bug 99205 – [BlackBerry] Only reallocate buffers that were allocated before suspending

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jakob Petsovits]

When we call releaseBuffers(), not all of the backingstore tile buffers might have been allocated yet. Still we try to release all of them, which causes us to lazy-initialize the tile buffers so we can release them again.

This is stupid and we should just ignore buffers that haven't been initialized yet. The patch below makes that change.

[Jakob Petsovits]

Created attachment 168496 [details]
Patch

The ChangeLog diff is off because of other local changes. Please review just the contents, I'll fix the ChangeLog conflicts before getting it into the commit queue. Thanks\!

[Antonio Gomes]

Comment on attachment 168496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168496&action=review

> Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp:104
> +    return static_cast<bool>(m_buffer);

is return m_buffer enough?

[Jakob Petsovits]

(In reply to comment #2)
> is return m_buffer enough?

Syntactically yes. I find it more explanatory with an explicit cast though.

[Jakob Petsovits]

Created attachment 168765 [details]
Patch

Better diff for ChangeLog (as promised above), with Antonio in the reviewer line. Thanks.

[WebKit Review Bot]

Comment on attachment 168765 [details]
Patch

Clearing flags on attachment: 168765

Committed r131364: <http://trac.webkit.org/changeset/131364>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.