Bug 99204 - ScrollingStateNodes should keep track of their IDs
Summary: ScrollingStateNodes should keep track of their IDs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 13:36 PDT by Beth Dakin
Modified: 2012-10-12 13:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.08 KB, patch)
2012-10-12 13:40 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (7.14 KB, patch)
2012-10-12 13:46 PDT, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-10-12 13:36:18 PDT
There is a HashMap in ScrollingCoordinatorMac that maps ScrollingNodeIDs to ScrollingStateNodes. The nodes themselves should keep track of this ID. Then the id can be used to make sure ScrollingStateNodes remove themselves from the HashMap when they are destroyed, and it will also be useful for associating ScrollingStateNodes with ScrollingTreeNodes over on the scrolling thread.
Comment 1 Beth Dakin 2012-10-12 13:40:08 PDT
Created attachment 168473 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-12 13:42:32 PDT
Attachment 168473 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/page/scrolling/ScrollingStateNode.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2012-10-12 13:46:57 PDT
Created attachment 168474 [details]
Patch
Comment 4 Beth Dakin 2012-10-12 13:50:52 PDT
Thanks, Simon! Committed change: http://trac.webkit.org/changeset/131221