Bug 99203 - Move QDataStream functions into HistoryItemQt.cpp
Summary: Move QDataStream functions into HistoryItemQt.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 99210
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-12 13:34 PDT by Anders Carlsson
Modified: 2012-10-14 17:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.97 KB, patch)
2012-10-12 13:38 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.48 KB, patch)
2012-10-12 14:01 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.02 KB, patch)
2012-10-12 16:50 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (8.59 KB, patch)
2012-10-12 17:55 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (8.61 KB, patch)
2012-10-12 18:24 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.67 KB, patch)
2012-10-14 16:12 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-12 13:34:35 PDT 
Move QDataStream functions into HistoryItemQt.cpp
Comment 1 Anders Carlsson 2012-10-12 13:38:12 PDT 
Created attachment 168472 [details]
Patch
Comment 2 Andreas Kling 2012-10-12 13:42:11 PDT 
Comment on attachment 168472 [details]
Patch

Fair enough, assuming EWS approves.
Comment 3 Early Warning System Bot 2012-10-12 13:53:48 PDT 
Comment on attachment 168472 [details]
Patch

Attachment 168472 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14272217
Comment 4 Early Warning System Bot 2012-10-12 13:59:40 PDT 
Comment on attachment 168472 [details]
Patch

Attachment 168472 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14266428
Comment 5 Anders Carlsson 2012-10-12 14:01:34 PDT 
Created attachment 168476 [details]
Patch
Comment 6 WebKit Review Bot 2012-10-12 14:04:41 PDT 
Attachment 168476 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/jsc.cpp', u'Source/W..." exit_code: 1
Source/JavaScriptCore/jsc.cpp:77:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2012-10-12 14:18:46 PDT 
Comment on attachment 168476 [details]
Patch

r=http://i.imgur.com/qUUgc.jpg
Comment 8 Early Warning System Bot 2012-10-12 14:18:49 PDT 
Comment on attachment 168476 [details]
Patch

Attachment 168476 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14293006
Comment 9 Anders Carlsson 2012-10-12 14:19:28 PDT 
Qt EWS is showing some super weird errors. I'm going to land temporarily and see if the bots show the same error.
Comment 10 Early Warning System Bot 2012-10-12 14:23:19 PDT 
Comment on attachment 168476 [details]
Patch

Attachment 168476 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14300005
Comment 11 Anders Carlsson 2012-10-12 14:26:26 PDT 
Committed r131224: <http://trac.webkit.org/changeset/131224>
Comment 12 WebKit Review Bot 2012-10-12 14:40:37 PDT 
Re-opened since this is blocked by bug 99210
Comment 13 Anders Carlsson 2012-10-12 16:50:54 PDT 
Created attachment 168514 [details]
Patch
Comment 14 Early Warning System Bot 2012-10-12 17:26:11 PDT 
Comment on attachment 168514 [details]
Patch

Attachment 168514 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14297075
Comment 15 Early Warning System Bot 2012-10-12 17:33:45 PDT 
Comment on attachment 168514 [details]
Patch

Attachment 168514 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14288092
Comment 16 Anders Carlsson 2012-10-12 17:55:37 PDT 
Created attachment 168519 [details]
Patch
Comment 17 Early Warning System Bot 2012-10-12 18:18:24 PDT 
Comment on attachment 168519 [details]
Patch

Attachment 168519 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14293086
Comment 18 Early Warning System Bot 2012-10-12 18:22:05 PDT 
Comment on attachment 168519 [details]
Patch

Attachment 168519 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14286086
Comment 19 Anders Carlsson 2012-10-12 18:24:39 PDT 
Created attachment 168526 [details]
Patch
Comment 20 Early Warning System Bot 2012-10-12 19:23:20 PDT 
Comment on attachment 168526 [details]
Patch

Attachment 168526 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14296093
Comment 21 Anders Carlsson 2012-10-14 16:12:49 PDT 
Created attachment 168597 [details]
Patch
Comment 22 Anders Carlsson 2012-10-14 16:40:06 PDT 
Committed r131279: <http://trac.webkit.org/changeset/131279>