Bug 99198 - Setup basic NetworkProcess messaging and initialization
Summary: Setup basic NetworkProcess messaging and initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 98537
  Show dependency treegraph
 
Reported: 2012-10-12 12:49 PDT by Brady Eidson
Modified: 2012-10-12 16:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch v1 (31.60 KB, patch)
2012-10-12 12:55 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch v2 (31.53 KB, patch)
2012-10-12 13:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch v3 - Now with binary correctness? (31.64 KB, patch)
2012-10-12 13:18 PDT, Brady Eidson
sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-10-12 12:49:43 PDT
Setup basic NetworkProcess messaging and initialization.

Working towards https://bugs.webkit.org/show_bug.cgi?id=98537 - Add a NetworkProcess to WebKit2
Comment 1 Brady Eidson 2012-10-12 12:55:22 PDT
Created attachment 168463 [details]
Patch v1
Comment 2 Brady Eidson 2012-10-12 13:12:38 PDT
Created attachment 168467 [details]
Patch v2

Dunno why that didn't apply... fresh rebase and new patch, let's try again.
Comment 3 Brady Eidson 2012-10-12 13:18:12 PDT
Created attachment 168469 [details]
Patch v3 - Now with binary correctness?
Comment 4 WebKit Review Bot 2012-10-12 13:28:48 PDT
Attachment 168469 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2012-10-12 13:54:26 PDT
Comment on attachment 168469 [details]
Patch v3 - Now with binary correctness?

Attachment 168469 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14254997
Comment 6 Brady Eidson 2012-10-12 14:01:05 PDT
(In reply to comment #5)
> (From update of attachment 168469 [details])
> Attachment 168469 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/14254997

9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2661: 'Messages::WebPageProxy::DidChangeScrollOffsetPinningForMainFrame::DidChangeScrollOffsetPinningForMainFrame' : no overloaded function takes 4 arguments
9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2780: 'bool CoreIPC::MessageSender<T>::send(const U &,uint64_t)' : expects 2 arguments - 1 provided
9>        with
9>        [
9>            T=WebKit::WebPage
9>        ]
9>        c:\cygwin\home\buildbot\WebKit\Source\WebKit2\Platform\CoreIPC\MessageSender.h(41) : see declaration of 'CoreIPC::MessageSender<T>::send'
9>        with
9>        [
9>            T=WebKit::WebPage
9>        ]

This is not related to this patch... EWS-fail?
Comment 7 Brady Eidson 2012-10-12 14:01:52 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 168469 [details] [details])
> > Attachment 168469 [details] [details] did not pass win-ews (win):
> > Output: http://queues.webkit.org/results/14254997
> 
> 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2661: 'Messages::WebPageProxy::DidChangeScrollOffsetPinningForMainFrame::DidChangeScrollOffsetPinningForMainFrame' : no overloaded function takes 4 arguments
> 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2780: 'bool CoreIPC::MessageSender<T>::send(const U &,uint64_t)' : expects 2 arguments - 1 provided
> 9>        with
> 9>        [
> 9>            T=WebKit::WebPage
> 9>        ]
> 9>        c:\cygwin\home\buildbot\WebKit\Source\WebKit2\Platform\CoreIPC\MessageSender.h(41) : see declaration of 'CoreIPC::MessageSender<T>::send'
> 9>        with
> 9>        [
> 9>            T=WebKit::WebPage
> 9>        ]
> 
> This is not related to this patch... EWS-fail?

Yup, EWS-fail:

8>Generating message receiver for WebIconDatabaseProxy...
8>Generating message receiver for WebInspector...
8>/bin/sh: fork: retry: Resource temporarily unavailable
8>/bin/sh: fork: retry: Resource temporarily unavailable
8>/bin/sh: fork: retry: Resource temporarily unavailable
8>/bin/sh: fork: retry: Resource temporarily unavailable
8>/bin/sh: fork: Resource temporarily unavailable
8>make: *** [WebInspectorMessages.h] Error 254
8>NMAKE : fatal error U1077: 'bash' : return code '0x2'
Comment 8 Brady Eidson 2012-10-12 16:39:18 PDT
http://trac.webkit.org/changeset/131235

(Weird that git/svn thought I copied a header into 4 new files...  oh well)