Bug 99197 - I pity da foo' who's converting numbers to strings
: I pity da foo' who's converting numbers to strings
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 99191
  Show dependency treegraph
 
Reported: 2012-10-12 12:19 PST by
Modified: 2012-10-13 09:51 PST (History)


Attachments
Patch (4.10 KB, patch)
2012-10-12 12:22 PST, Geoffrey Garen
barraclough: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-10-12 12:19:54 PST
I pity da foo' who's converting numbers to strings
------- Comment #1 From 2012-10-12 12:21:47 PST -------
So the commit message for this will just be a quickmeme link?
------- Comment #2 From 2012-10-12 12:22:55 PST -------
Created an attachment (id=168462) [details]
Patch
------- Comment #3 From 2012-10-12 12:29:59 PST -------
(From update of attachment 168462 [details])
I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?
------- Comment #4 From 2012-10-12 15:46:12 PST -------
> I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?

Darin mentioned this, too. Let's drive this based on how common that scenario is.
------- Comment #5 From 2012-10-13 09:51:22 PST -------
(Side note: it's entirely possible that, if we did the research to implement canGetItemsForIndex(), we would discover that it's a no-op that always returns false.)
------- Comment #6 From 2012-10-13 09:51:52 PST -------
Committed: <http://trac.webkit.org/changeset/131258>.