Bug 99197 - I pity da foo' who's converting numbers to strings
: I pity da foo' who's converting numbers to strings
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Geoffrey Garen
:
Depends on:
Blocks: 99191
  Show dependency treegraph
 
Reported: 2012-10-12 12:19 PDT by Geoffrey Garen
Modified: 2012-10-13 09:51 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.10 KB, patch)
2012-10-12 12:22 PDT, Geoffrey Garen
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-10-12 12:19:54 PDT
I pity da foo' who's converting numbers to strings
Comment 1 Filip Pizlo 2012-10-12 12:21:47 PDT
So the commit message for this will just be a quickmeme link?
Comment 2 Geoffrey Garen 2012-10-12 12:22:55 PDT
Created attachment 168462 [details]
Patch
Comment 3 Gavin Barraclough 2012-10-12 12:29:59 PDT
Comment on attachment 168462 [details]
Patch

I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?
Comment 4 Geoffrey Garen 2012-10-12 15:46:12 PDT
> I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?

Darin mentioned this, too. Let's drive this based on how common that scenario is.
Comment 5 Geoffrey Garen 2012-10-13 09:51:22 PDT
(Side note: it's entirely possible that, if we did the research to implement canGetItemsForIndex(), we would discover that it's a no-op that always returns false.)
Comment 6 Geoffrey Garen 2012-10-13 09:51:52 PDT
Committed: <http://trac.webkit.org/changeset/131258>.