RESOLVED FIXED 99189
[Cairo] Pixel regressions after the update to 1.12.4 
https://bugs.webkit.org/show_bug.cgi?id=99189
Summary [Cairo] Pixel regressions after the update to 1.12.4
Raphael Kubo da Costa (:rakuco)
Reported 2012-10-12 10:49:06 PDT
The following tests have regressed since the latest Cairo update (images are drawn when they were not expected to be drawn, some borders are drawn wrongly etc): fast/backgrounds/background-leakage-transforms.html fast/borders/borderRadiusAllStylesAllCorners.html fast/borders/borderRadiusAllStylesAllCorners.html fast/borders/borderRadiusDashed02.html fast/borders/borderRadiusDashed03.html fast/borders/borderRadiusDashed04.html fast/borders/borderRadiusDashed05.html fast/borders/borderRadiusDashed06.html fast/borders/borderRadiusDotted01.html fast/borders/borderRadiusDotted02.html fast/borders/borderRadiusDotted03.html fast/borders/borderRadiusDotted04.html fast/borders/borderRadiusDotted06.html fast/box-shadow/box-shadow-transformed.html fast/box-shadow/transform-fringing.html I can't remember if the following ones have started failing after the update or if fail because of something else (nothing is rendered at all): fast/borders/inline-mask-overlay-image-outset-vertical-rl.html fast/borders/inline-mask-overlay-image-outset.html fast/borders/inline-mask-overlay-image.html
Attachments
Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-10-12 10:52:01 PDT
ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm as well.
Dominik Röttsches (drott)
Comment 2 2012-10-26 08:52:28 PDT
(In reply to comment #1) > ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm > ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm git bisect ftw: these ones are broken after cairo commit b66065537cec5f03b33f7513f06e26630c28b5f1.
Sudarsana Nagineni (babu)
Comment 3 2012-10-26 09:19:13 PDT
borderRadiusDashed/Dotted* tests started failing after cairo commits cd1004ce1 and 4ea3ace6c.
Dominik Röttsches (drott)
Comment 4 2012-10-29 06:13:29 PDT
Sorry, it was the one before 99593538a9d054aa1bb9fa620f.(In reply to comment #2) > (In reply to comment #1) > > ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm > > ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm > > git bisect ftw: these ones are broken after cairo commit b66065537cec5f03b33f7513f06e26630c28b5f1. Sorry, it was the one following: 99593538a9d054aa1bb9fa620f.
Dominik Röttsches (drott)
Comment 5 2012-10-29 06:14:15 PDT
(In reply to comment #4) > Sorry, it was the one following: 99593538a9d054aa1bb9fa620f. s/following/preceding.
Dominik Röttsches (drott)
Comment 6 2012-10-30 01:40:26 PDT
fast/borders/borderRadiusDashed04.html fast/borders/borderRadiusAllStylesAllCorners.html fast/backgrounds/background-leakage-transforms.html fast/box-shadow/transform-fringing.html fast/box-shadow/box-shadow-transformed.html Fail, even crash according to DRT/WTR with cd1004ce1.
Dominik Röttsches (drott)
Comment 7 2012-10-30 01:45:05 PDT
> ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm > ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm Tracked in https://bugs.freedesktop.org/show_bug.cgi?id=56432 > fast/borders/borderRadiusDashed04.html > fast/borders/borderRadiusAllStylesAllCorners.html > fast/backgrounds/background-leakage-transforms.html > fast/box-shadow/transform-fringing.html > fast/box-shadow/box-shadow-transformed.html Tracked in https://bugs.freedesktop.org/show_bug.cgi?id=56574
Sudarsana Nagineni (babu)
Comment 8 2012-11-05 07:05:40 PST
The following tests are failing with the old cairo version 1.10.2 also. These are not regressions. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html fast/borders/inline-mask-overlay-image-outset.html fast/borders/inline-mask-overlay-image.html
Sudarsana Nagineni (babu)
Comment 9 2012-11-05 07:40:55 PST
Only the following two tests are now failing with the latest cairo release 1.12.8. fast/box-shadow/box-shadow-transformed.html fast/box-shadow/transform-fringing.html
Kangil Han
Comment 10 2012-12-05 18:33:11 PST
(In reply to comment #9) > Only the following two tests are now failing with the latest cairo release 1.12.8. > > fast/box-shadow/box-shadow-transformed.html > fast/box-shadow/transform-fringing.html If so, why don't we bump?
Chris Dumez
Comment 11 2012-12-30 08:05:09 PST
All these tests seem to be passing now (despite us still using cairo 1.12.4). I unskipped them in http://trac.webkit.org/changeset/138578. Are we sure these were cairo regressions? Our snapshot taking code was buggy as well causing a lot of failures in ref tests (Bug 103468). I fixed that bug recently, it may be related?
Chris Dumez
Comment 12 2012-12-30 08:14:04 PST
I can only see the last 200 builds on the build bot so I unfortunately don't know when the tests started passing yet. Is there a way we get see results of older builds?
Kangil Han
Comment 13 2012-12-30 18:03:42 PST
(In reply to comment #12) > I can only see the last 200 builds on the build bot so I unfortunately don't know when the tests started passing yet. Is there a way we get see results of older builds? From <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/6715>, it's been passed.
Dominik Röttsches (drott)
Comment 14 2013-01-04 09:21:56 PST
Can someone check whether the test expectations are okay?
Raphael Kubo da Costa (:rakuco)
Comment 15 2013-02-27 07:17:01 PST
fast/box-shadow/box-shadow-transformed.html is the only test that's failing these days, and only on WK1, so I guess we can close this one.
Note You need to log in before you can comment on or make changes to this bug.