Bug 99170 - Web Inspector: [Styles] !important priority not honored inside the same declaration
Summary: Web Inspector: [Styles] !important priority not honored inside the same decla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 06:05 PDT by Alexander Pavlov (apavlov)
Modified: 2012-10-12 08:18 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.19 KB, patch)
2012-10-12 07:18 PDT, Alexander Pavlov (apavlov) 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-10-12 06:05:09 PDT 
The Styles pane displaying

div {
    height: 30px !important;
    height: 20px;
}

shows the first !important property as overridden, even though it takes precedence over the second one.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=131749
Comment 1 Alexander Pavlov (apavlov) 2012-10-12 07:18:19 PDT 
Created attachment 168417 [details]
Patch
Comment 2 Yury Semikhatsky 2012-10-12 07:37:28 PDT 
Comment on attachment 168417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168417&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:542
> +                                shouldInactivate = true;

shouldInactivate -> shouldInactivatePrevious
Comment 3 WebKit Review Bot 2012-10-12 08:05:15 PDT 
Comment on attachment 168417 [details]
Patch

Attachment 168417 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14266337

New failing tests:
inspector/styles/styles-overriden-properties.html
inspector/styles/styles-new-API.html
Comment 4 Alexander Pavlov (apavlov) 2012-10-12 08:18:24 PDT 
Committed r131187: <http://trac.webkit.org/changeset/131187>