Bug 99164 - Web Inspector: relies on current Function.prototype.bind in the frame
Summary: Web Inspector: relies on current Function.prototype.bind in the frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 05:01 PDT by Pavel Feldman
Modified: 2012-10-12 05:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2012-10-12 05:03 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-10-12 05:01:14 PDT 
InjectedScriptSource should not depend on the bind override.
Comment 1 Pavel Feldman 2012-10-12 05:03:31 PDT 
Created attachment 168397 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-10-12 05:27:20 PDT 
Comment on attachment 168397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168397&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:58
> +    function bound()

Could you please add var_args here?
Comment 3 Yury Semikhatsky 2012-10-12 05:27:41 PDT 
Comment on attachment 168397 [details]
Patch

Let's use closure instead in the two places where the bind is used.
Comment 4 Pavel Feldman 2012-10-12 05:36:06 PDT 
Committed r131178: <http://trac.webkit.org/changeset/131178>