Bug 99117 - Move TransformState code into its own member function, and remove a test that was prematurely added
Summary: Move TransformState code into its own member function, and remove a test that...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 16:44 PDT by Simon Fraser (smfr)
Modified: 2012-10-12 18:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.17 KB, patch)
2012-10-11 16:45 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-11 16:44:21 PDT
Move TransformState code into its own member function, and remove a test that was prematurely added
Comment 1 Simon Fraser (smfr) 2012-10-11 16:45:45 PDT
Created attachment 168315 [details]
Patch
Comment 2 Tim Horton 2012-10-11 16:49:30 PDT
Comment on attachment 168315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168315&action=review

> Source/WebCore/ChangeLog:8
> +        The code that manipulates the TransormState and computes the visible rect is going to get

typo Transform

> Source/WebCore/ChangeLog:11
> +        Remove a test that wasn't supposed to be added yet.

Unclear why these are in the same patch. (what would happen if someone wanted to roll out the TransformState change?)

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:950
> +    // Save the state before sending down to kids and restore it after

Punctuation.
Comment 3 Simon Fraser (smfr) 2012-10-12 18:18:06 PDT
http://trac.webkit.org/changeset/131247