Bug 99093 - IndexedDB: IDL types defined in spec should be visible to scripts
Summary: IndexedDB: IDL types defined in spec should be visible to scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 13:18 PDT by Joshua Bell
Modified: 2012-10-11 14:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.81 KB, patch)
2012-10-11 13:19 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (7.73 KB, patch)
2012-10-11 13:40 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-10-11 13:18:21 PDT
IndexedDB: IDL types defined in spec should be visible to scripts
Comment 1 Joshua Bell 2012-10-11 13:19:59 PDT
Created attachment 168266 [details]
Patch
Comment 2 Joshua Bell 2012-10-11 13:21:12 PDT
alecflett@, dgrogan@ - please take a look.

With this we pass http://w3c-test.org/webapps/IndexedDB/tests/submissions/Opera/idbtransaction.htm
Comment 3 David Grogan 2012-10-11 13:30:46 PDT
LGTM

I don't know why this is necessary, but I believe you that it is. Seems harmless.

removeVendorPrefixes() in shared.js has a similar check (shouldBeTrueQuiet...).  You might want to update that instead of or in addition to the layout test you have here.
Comment 4 Adam Barth 2012-10-11 13:32:47 PDT
> I don't know why this is necessary, but I believe you that it is. Seems harmless.

You don't know why exposing these properties is necessary from an API point of view or why we need to declare them explicitly in the IDL from an implementation point of view?
Comment 5 David Grogan 2012-10-11 13:33:39 PDT
(In reply to comment #4)
> > I don't know why this is necessary, but I believe you that it is. Seems harmless.
> 
> You don't know why exposing these properties is necessary from an API point of view or why we need to declare them explicitly in the IDL from an implementation point of view?

The first.
Comment 6 Adam Barth 2012-10-11 13:36:54 PDT
Typically its so web pages can manipulate the prototypes of these objects, for example to shim in future versions of the API.
Comment 7 David Grogan 2012-10-11 13:38:52 PDT
(In reply to comment #6)
> Typically its so web pages can manipulate the prototypes of these objects, for example to shim in future versions of the API.

Got it, that makes sense. Josh also mentioned that this could allow for easier feature detection.
Comment 8 Joshua Bell 2012-10-11 13:40:34 PDT
Created attachment 168268 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-10-11 14:37:11 PDT
Comment on attachment 168268 [details]
Patch for landing

Clearing flags on attachment: 168268

Committed r131096: <http://trac.webkit.org/changeset/131096>
Comment 10 WebKit Review Bot 2012-10-11 14:37:14 PDT
All reviewed patches have been landed.  Closing bug.