Bug 99076 - [Qt][WK2] GraphicsSurfaceGLX should keep track of previous GL context.
Summary: [Qt][WK2] GraphicsSurfaceGLX should keep track of previous GL context.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 08:31 PDT by Zeno Albisser
Modified: 2012-10-12 02:37 PDT (History)
1 user (show)

See Also:

Attachments
patch for review. (1.98 KB, patch)
2012-10-11 08:40 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-10-11 08:31:36 PDT 
In GraphicsSurfaceGLX / GraphicsSurfacePrivate constructor we create a new GL context for resolving GL functions.
The QOpenGLContext implementation for GLX makes this context current by default. Therefore we have to keep track of the previous context and make that one current again after the creation.
Comment 1 Zeno Albisser 2012-10-11 08:40:53 PDT 
Created attachment 168233 [details]
patch for review.
Comment 2 Zeno Albisser 2012-10-12 02:36:58 PDT 
Comment on attachment 168233 [details]
patch for review.

Clearing flags on attachment: 168233

Committed r131164: <http://trac.webkit.org/changeset/131164>
Comment 3 Zeno Albisser 2012-10-12 02:37:03 PDT 
All reviewed patches have been landed.  Closing bug.