Bug 99030 - [CMAKE] Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature
Summary: [CMAKE] Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 05:45 PDT by Jinwoo Song
Modified: 2012-10-11 19:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2012-10-11 07:45 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-10-11 05:45:34 PDT 
Add newly added HIDDEN_PAGE_DOM_TIMER_THROTTLING which throttle DOM timers on hidden pages to WebKitFeatures.cmake.
Comment 1 Jinwoo Song 2012-10-11 07:45:34 PDT 
Created attachment 168227 [details]
Patch
Comment 2 Laszlo Gombos 2012-10-11 16:33:19 PDT 
Comment on attachment 168227 [details]
Patch

I am not sure if the current way is the best way to handle these build options, but this patch is consistent with the existing idiom. r=me.
Comment 3 Jinwoo Song 2012-10-11 17:38:53 PDT 
(In reply to comment #2)
> (From update of attachment 168227 [details])
> I am not sure if the current way is the best way to handle these build options, but this patch is consistent with the existing idiom. r=me.

I know there is a movement to clean up the build options and hope that will be clean the options more smartly. Thanks for r+. :)
Comment 4 WebKit Review Bot 2012-10-11 19:06:30 PDT 
Comment on attachment 168227 [details]
Patch

Clearing flags on attachment: 168227

Committed r131122: <http://trac.webkit.org/changeset/131122>
Comment 5 WebKit Review Bot 2012-10-11 19:06:35 PDT 
All reviewed patches have been landed.  Closing bug.