Bug 99012 - [WebKit IDL] move extended attributes to left of interface, exception...
Summary: [WebKit IDL] move extended attributes to left of interface, exception...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 98980
  Show dependency tree / graph
 
Reported: 2012-10-11 01:14 PDT by Takashi Sakamoto
Modified: 2012-10-12 04:45 PDT (History)
18 users (show)

See Also:

Attachments
Patch (521.05 KB, patch)
2012-10-12 04:18 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2012-10-11 01:14:01 PDT 
WebIDL spec, http://www.w3.org/TR/WebIDL/#idl-grammar, says:

[1]	Definitions -> ExtendedAttributeList Definition Definitions 
[2]	Definition   -> CallbackOrInterface | Partial | Dictionary  | Exception  | Enum  | Typedef  | ImplementsStatement

However, current WebKit IDL grammar is different from the above, e.g.

    interface [
        JSGenerateToNativeObject,
        JSInlineGetOwnPropertySlot
    ] Element : Node {
    ...

ExtendedAttributeList is placed at the right of "interface". So move extended attributes in idl files to correct position.
Comment 1 Takashi Sakamoto 2012-10-12 04:18:47 PDT 
Created attachment 168390 [details]
Patch
Comment 2 Kentaro Hara 2012-10-12 04:27:33 PDT 
Comment on attachment 168390 [details]
Patch

Great patch. Let's remove the old syntax from IDLParser.pm in a follow-up patch.
Comment 3 WebKit Review Bot 2012-10-12 04:45:09 PDT 
Comment on attachment 168390 [details]
Patch

Clearing flags on attachment: 168390

Committed r131172: <http://trac.webkit.org/changeset/131172>
Comment 4 WebKit Review Bot 2012-10-12 04:45:14 PDT 
All reviewed patches have been landed.  Closing bug.