WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
99010
Fix memory leak for the Pasteboard singleton
https://bugs.webkit.org/show_bug.cgi?id=99010
Summary
Fix memory leak for the Pasteboard singleton
Mariusz Grzegorczyk
Reported
2012-10-11 01:12:04 PDT
All ports have generalPasteboard() implementation looks similar to: Pasteboard* Pasteboard::generalPasteboard() { static Pasteboard* pasteboard = new Pasteboard(); return pasteboard; } Because of this, memory is not deallocated at application exit.
Attachments
patch
(8.69 KB, patch)
2012-10-11 01:16 PDT
,
Mariusz Grzegorczyk
andersca
: review-
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mariusz Grzegorczyk
Comment 1
2012-10-11 01:16:28 PDT
Created
attachment 168165
[details]
patch
Build Bot
Comment 2
2012-10-11 01:23:51 PDT
Comment on
attachment 168165
[details]
patch
Attachment 168165
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/14252500
Anders Carlsson
Comment 3
2012-10-11 11:54:29 PDT
Comment on
attachment 168165
[details]
patch No. Nowhere in WebKit do we free memory at exit; the OS is much better at doing that. In fact - we have warnings in place to catch this behavior and that's why the Mac build is failing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug