Bug 99007 – [WebKit IDL] remove all module from idl files.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Takashi Sakamoto]

Now WebIDL spec, c.f. http://www.w3.org/TR/WebIDL/, doesn't have "module":

07 February 2012 – LCWD #3
Removed modules and [NamespaceObject].

And WebKit uses "module", but no code is generated from "module". 
For example, the following (before) will be modified into the following (after).

(before)
module SomeModule {
   interface [] someInterface {
    ...
   };
}

(after)
interface [] someInterface {
  ...
};

[Takashi Sakamoto]

Created attachment 168167 [details]
A list of IDL files to be fixed.

This file is created by running "find . -name \*.idl" under third_party/WebKit directory.
And removed windows idl files, i.e. idl files under ./Source/WebKit/win/Interfaces/.

$ find . -name \*.idl | grep -v "./Source/WebKit/win/Interfaces" > IDLFiles.txt
$ wc -l IDLFiles.txt
641 IDLFiles.txt

[Takashi Sakamoto]

Created attachment 168169 [details]
remove_module.py

A script to just remove "module {" ... "}" from idl files.

$ python remove_module.py IDLFiles.txt
convert ....
convert ....
convert ....

$

[Takashi Sakamoto]

Created attachment 168179 [details]
Patch

[Kentaro Hara]

Comment on attachment 168179 [details]
Patch

- Let's remove the "module" logic from IDLParser.pm in a follow-up patch.

- This patch might break some internal build (e.g. Safari internal build as we experienced before). Please land it when you can keep watching IRC.

[Takashi Sakamoto]

Created attachment 168345 [details]
Patch for landing

[Kentaro Hara]

Comment on attachment 168345 [details]
Patch for landing

Maybe you need to rebase with ToT? Bots are not green.

[Takashi Sakamoto]

Created attachment 168360 [details]
Patch for landing

[Takashi Sakamoto]

(In reply to comment #6)
> (From update of attachment 168345 [details])
> Maybe you need to rebase with ToT? Bots are not green.

Yeah. The patch conflicts my another patch... 
I have just rebased.

Best regards,
Takashi Sakamoto

[WebKit Review Bot]

Comment on attachment 168360 [details]
Patch for landing

Clearing flags on attachment: 168360

Committed r131145: <http://trac.webkit.org/changeset/131145>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.