Bug 99007 - [WebKit IDL] remove all module from idl files.
Summary: [WebKit IDL] remove all module from idl files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 98980
  Show dependency tree / graph
 
Reported: 2012-10-11 01:06 PDT by Takashi Sakamoto
Modified: 2013-03-07 02:58 PST (History)
20 users (show)

See Also:

Attachments
A list of IDL files to be fixed. (29.66 KB, text/plain)
2012-10-11 01:22 PDT, Takashi Sakamoto 		no flags Details
remove_module.py (1.29 KB, text/plain)
2012-10-11 01:24 PDT, Takashi Sakamoto 		no flags Details
Patch (1.32 MB, patch)
2012-10-11 02:46 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch for landing (1.32 MB, patch)
2012-10-11 20:36 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch for landing (1.32 MB, patch)
2012-10-11 22:38 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2012-10-11 01:06:20 PDT 
Now WebIDL spec, c.f. http://www.w3.org/TR/WebIDL/, doesn't have "module":

07 February 2012 – LCWD #3
Removed modules and [NamespaceObject].

And WebKit uses "module", but no code is generated from "module". 
For example, the following (before) will be modified into the following (after).

(before)
module SomeModule {
   interface [] someInterface {
    ...
   };
}

(after)
interface [] someInterface {
  ...
};
Comment 1 Takashi Sakamoto 2012-10-11 01:22:21 PDT 
Created attachment 168167 [details]
A list of IDL files to be fixed.

This file is created by running "find . -name \*.idl" under third_party/WebKit directory.
And removed windows idl files, i.e. idl files under ./Source/WebKit/win/Interfaces/.

$ find . -name \*.idl | grep -v "./Source/WebKit/win/Interfaces" > IDLFiles.txt
$ wc -l IDLFiles.txt
641 IDLFiles.txt
Comment 2 Takashi Sakamoto 2012-10-11 01:24:06 PDT 
Created attachment 168169 [details]
remove_module.py

A script to just remove "module {" ... "}" from idl files.

$ python remove_module.py IDLFiles.txt
convert ....
convert ....
convert ....

$
Comment 3 Takashi Sakamoto 2012-10-11 02:46:04 PDT 
Created attachment 168179 [details]
Patch
Comment 4 Kentaro Hara 2012-10-11 02:53:18 PDT 
Comment on attachment 168179 [details]
Patch

- Let's remove the "module" logic from IDLParser.pm in a follow-up patch.

- This patch might break some internal build (e.g. Safari internal build as we experienced before). Please land it when you can keep watching IRC.
Comment 5 Takashi Sakamoto 2012-10-11 20:36:45 PDT 
Created attachment 168345 [details]
Patch for landing
Comment 6 Kentaro Hara 2012-10-11 21:52:15 PDT 
Comment on attachment 168345 [details]
Patch for landing

Maybe you need to rebase with ToT? Bots are not green.
Comment 7 Takashi Sakamoto 2012-10-11 22:38:49 PDT 
Created attachment 168360 [details]
Patch for landing
Comment 8 Takashi Sakamoto 2012-10-11 22:39:02 PDT 
(In reply to comment #6)
> (From update of attachment 168345 [details])
> Maybe you need to rebase with ToT? Bots are not green.

Yeah. The patch conflicts my another patch... 
I have just rebased.

Best regards,
Takashi Sakamoto
Comment 9 WebKit Review Bot 2012-10-11 23:10:46 PDT 
Comment on attachment 168360 [details]
Patch for landing

Clearing flags on attachment: 168360

Committed r131145: <http://trac.webkit.org/changeset/131145>
Comment 10 WebKit Review Bot 2012-10-11 23:10:51 PDT 
All reviewed patches have been landed.  Closing bug.