Bug 99004 - Fix committers.py for the names of contributors to appear on webkit.org/team.html
Summary: Fix committers.py for the names of contributors to appear on webkit.org/team....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 00:58 PDT by Vivek Galatage
Modified: 2012-10-11 13:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2012-10-11 01:15 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-10-11 00:58:47 PDT
Fix committers.py for the names of contributors to appear on webkit.org/team.html
Comment 1 Vivek Galatage 2012-10-11 01:15:25 PDT
Created attachment 168163 [details]
Patch
Comment 2 Yuta Kitamura 2012-10-11 01:29:21 PDT
Comment on attachment 168163 [details]
Patch

I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave
this style inconsistencies.
Comment 3 WebKit Review Bot 2012-10-11 01:52:42 PDT
Comment on attachment 168163 [details]
Patch

Clearing flags on attachment: 168163

Committed r131029: <http://trac.webkit.org/changeset/131029>
Comment 4 WebKit Review Bot 2012-10-11 01:52:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Vivek Galatage 2012-10-11 02:28:43 PDT
(In reply to comment #2)
> (From update of attachment 168163 [details])
> I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave
> this style inconsistencies.

The JSON specification specifies about using the strings only with ("). Also its stated here http://stackoverflow.com/questions/2275359/jquery-single-quote-in-json-response?answertab=votes#tab-top 

Some of the implementations(as stated in above link: java) might allow the (') strings. 

I verified with all leading browsers(FF, Opera) (fiddle link: http://jsfiddle.net/4bwrC/ ) and all of them don't support this.

The errors are reported from here:

JSC: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp#L274

V8:
Source/WebKit/chromium/v8/src/messages.js Line: 145
Comment 6 Alexey Proskuryakov 2012-10-11 13:24:44 PDT
I'm confused. When did names from committers.py become published on webkit.org/team.html? Have these persons given their permission for that?