Bug 99004 – Fix committers.py for the names of contributors to appear on webkit.org/team.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vivek Galatage]

Fix committers.py for the names of contributors to appear on webkit.org/team.html

[Vivek Galatage]

Created attachment 168163 [details]
Patch

[Yuta Kitamura]

Comment on attachment 168163 [details]
Patch

I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave
this style inconsistencies.

[WebKit Review Bot]

Comment on attachment 168163 [details]
Patch

Clearing flags on attachment: 168163

Committed r131029: <http://trac.webkit.org/changeset/131029>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Vivek Galatage]

(In reply to comment #2)
> (From update of attachment 168163 [details])
> I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave
> this style inconsistencies.

The JSON specification specifies about using the strings only with ("). Also its stated here http://stackoverflow.com/questions/2275359/jquery-single-quote-in-json-response?answertab=votes#tab-top 

Some of the implementations(as stated in above link: java) might allow the (') strings. 

I verified with all leading browsers(FF, Opera) (fiddle link: http://jsfiddle.net/4bwrC/ ) and all of them don't support this.

The errors are reported from here:

JSC: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp#L274

V8:
Source/WebKit/chromium/v8/src/messages.js Line: 145

[Alexey Proskuryakov]

I'm confused. When did names from committers.py become published on webkit.org/team.html? Have these persons given their permission for that?