Bug 98992 - Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
Summary: Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 99291
  Show dependency tree / graph
 
Reported: 2012-10-10 22:04 PDT by Kent Tamura
Modified: 2012-10-14 21:33 PDT (History)
4 users (show)

See Also:

Attachments
WIP (11.98 KB, patch)
2012-10-10 22:11 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (12.75 KB, patch)
2012-10-11 00:15 PDT, Kent Tamura 		haraken: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-10 22:04:03 PDT 
Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
Comment 1 Kent Tamura 2012-10-10 22:11:26 PDT 
Created attachment 168143 [details]
WIP
Comment 2 Kent Tamura 2012-10-11 00:15:20 PDT 
Created attachment 168151 [details]
Patch
Comment 3 Kentaro Hara 2012-10-11 00:22:28 PDT 
Comment on attachment 168151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168151&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Nit: Remove this line.
Comment 4 Kent Tamura 2012-10-11 00:45:30 PDT 
Committed r131021: <http://trac.webkit.org/changeset/131021>
Comment 5 Kent Tamura 2012-10-11 02:26:42 PDT 
A follow-up change: https://trac.webkit.org/changeset/131030
We needed to initialize "UErrorCode status" with U_ZERO_ERROR.