Bug 98983 – [Chromium] Calendar picker: should use consistent Localizer object

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Calendar picker: should use consistent Localizer object

In WebKit/chromium/src/DateTimeChooserImpl.cpp, we use two Localizer objects, one if m_localizer and another is 'localizer' local object in writeDocument. We should use single Localizer object.

[Kent Tamura]

Created attachment 168133 [details]
Patch

[Kentaro Hara]

Comment on attachment 168133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review

Looks reasonable

> Source/WebKit/chromium/ChangeLog:15
> +        environment; e.g. Month labels in a calendar picker were numeric. This
> +        patch fixes it, and this is covered by
> +        fast/forms/date/calendar-picker-appearance.html.

No change in the test result? Or you might want to add a new test that covers this change.

[Kent Tamura]

Comment on attachment 168133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review

>> Source/WebKit/chromium/ChangeLog:15
>> +        fast/forms/date/calendar-picker-appearance.html.
> 
> No change in the test result? Or you might want to add a new test that covers this change.

The test is already marked as failure in TestExpectations.   I won't add image results to this patch because I don't have handy Linux (ICU) environment.

[Kentaro Hara]

Comment on attachment 168133 [details]
Patch

Makes sense.

[Kent Tamura]

FYI. See Linux results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=calendar-picker-appearance.html

[WebKit Review Bot]

Comment on attachment 168133 [details]
Patch

Clearing flags on attachment: 168133

Committed r131011: <http://trac.webkit.org/changeset/131011>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.