Bug 98981 - Add more Objective-C WebKit2 DOM API skeletons.
Summary: Add more Objective-C WebKit2 DOM API skeletons.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 20:03 PDT by Sam Weinig
Modified: 2012-10-11 17:46 PDT (History)
2 users (show)

See Also:


Attachments
Patch (33.99 KB, patch)
2012-10-10 20:07 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-10-10 20:03:27 PDT
Add more Objective-C WebKit2 DOM API skeletons.
Comment 1 Sam Weinig 2012-10-10 20:07:50 PDT
Created attachment 168132 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-10 20:11:21 PDT
Attachment 168132 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:50:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:39:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:40:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:41:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2012-10-10 20:13:33 PDT
Committed r131003: <http://trac.webkit.org/changeset/131003>
Comment 4 Adam Barth 2012-10-11 09:22:30 PDT
Just curious, are you planning to write these all by hand, or do you plan to autogenerate them from the IDL at some point?
Comment 5 Sam Weinig 2012-10-11 17:46:32 PDT
(In reply to comment #4)
> Just curious, are you planning to write these all by hand, or do you plan to autogenerate them from the IDL at some point?

Not sure yet.  Depends on how they shape up.  That said, I really have no interest in exposing the whole DOM (its huge, and no one uses most of it), only a useful subset.