Bug 98981 – Add more Objective-C WebKit2 DOM API skeletons.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add more Objective-C WebKit2 DOM API skeletons.

[Sam Weinig]

Created attachment 168132 [details]
Patch

[WebKit Review Bot]

Attachment 168132 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:50:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:39:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:40:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:41:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Committed r131003: <http://trac.webkit.org/changeset/131003>

[Adam Barth]

Just curious, are you planning to write these all by hand, or do you plan to autogenerate them from the IDL at some point?

[Sam Weinig]

(In reply to comment #4)
> Just curious, are you planning to write these all by hand, or do you plan to autogenerate them from the IDL at some point?

Not sure yet.  Depends on how they shape up.  That said, I really have no interest in exposing the whole DOM (its huge, and no one uses most of it), only a useful subset.