Bug 98974 - [CSS Shaders] Validate types of built-in uniforms
Summary: [CSS Shaders] Validate types of built-in uniforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 71392
  Show dependency treegraph
 
Reported: 2012-10-10 17:24 PDT by Max Vujovic
Modified: 2012-10-31 15:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (12.12 KB, patch)
2012-10-30 09:28 PDT, Max Vujovic
dino: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (12.12 KB, patch)
2012-10-31 11:27 PDT, Max Vujovic
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2012-10-10 17:24:42 PDT
When an author defines a built-in uniform, WebKit should check its type.

For example, the following should be an error because u_textureSize should be a vec2, not a float:
attribute float u_textureSize;

Built-in uniforms list: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
Comment 1 Max Vujovic 2012-10-30 09:28:02 PDT
Created attachment 171467 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-31 02:48:59 PDT
Comment on attachment 171467 [details]
Patch

Rejecting attachment 171467 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 1

Died at Tools/Scripts/update-webkit line 154.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9
/video-* tests on Linux and Mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14561173
Comment 3 Max Vujovic 2012-10-31 11:27:33 PDT
Created attachment 171694 [details]
Patch

Rebased patch.

Thanks for the review, Dean!
Comment 4 WebKit Review Bot 2012-10-31 15:14:18 PDT
Comment on attachment 171694 [details]
Patch

Clearing flags on attachment: 171694

Committed r133083: <http://trac.webkit.org/changeset/133083>
Comment 5 WebKit Review Bot 2012-10-31 15:14:21 PDT
All reviewed patches have been landed.  Closing bug.