When an author defines a built-in uniform, WebKit should check its type. For example, the following should be an error because u_textureSize should be a vec2, not a float: attribute float u_textureSize; Built-in uniforms list: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
Created attachment 171467 [details] Patch
Comment on attachment 171467 [details] Patch Rejecting attachment 171467 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 1 Died at Tools/Scripts/update-webkit line 154. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 /video-* tests on Linux and Mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14561173
Created attachment 171694 [details] Patch Rebased patch. Thanks for the review, Dean!
Comment on attachment 171694 [details] Patch Clearing flags on attachment: 171694 Committed r133083: <http://trac.webkit.org/changeset/133083>
All reviewed patches have been landed. Closing bug.