Bug 98971 - Disallow full screen mode keyboard access by default.
Summary: Disallow full screen mode keyboard access by default.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-10 17:05 PDT by Jer Noble
Modified: 2012-10-10 23:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2012-10-10 17:10 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2012-10-10 17:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-10-10 17:05:07 PDT 
Disallow full screen mode keyboard access by default.
Comment 1 Jer Noble 2012-10-10 17:09:24 PDT 
Clients can override the default behavior (through the WebView delegate in WebKit, and through the InjectedBundlePageFullScreenClient interface in WebKit2).  But by default, keyboard access should be denied.
Comment 2 Jer Noble 2012-10-10 17:09:39 PDT 
<rdar://problem/12474226>
Comment 3 Jer Noble 2012-10-10 17:10:46 PDT 
Created attachment 168102 [details]
Patch
Comment 4 Jer Noble 2012-10-10 17:12:56 PDT 
Created attachment 168103 [details]
Patch

Added radar link to ChangeLogs
Comment 5 Maciej Stachowiak 2012-10-10 19:14:08 PDT 
Does this change the behavior for other ports?
Comment 6 Jer Noble 2012-10-10 21:17:07 PDT 
(In reply to comment #5)
> Does this change the behavior for other ports?

Yes it does. Ports can override this default, but only Chromium does.
Comment 7 Maciej Stachowiak 2012-10-10 22:39:47 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Does this change the behavior for other ports?
> 
> Yes it does. Ports can override this default, but only Chromium does.

OK. It's likely that other non-Chromium ports only got the keyboard access support by accident, then.
Comment 8 WebKit Review Bot 2012-10-10 23:40:00 PDT 
Comment on attachment 168103 [details]
Patch

Clearing flags on attachment: 168103

Committed r131018: <http://trac.webkit.org/changeset/131018>
Comment 9 WebKit Review Bot 2012-10-10 23:40:03 PDT 
All reviewed patches have been landed.  Closing bug.