Bug 98969 - [texmap] logic error in BitmapTextureGL::updateContents
Summary: [texmap] logic error in BitmapTextureGL::updateContents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: arno.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 16:53 PDT by arno.
Modified: 2012-10-11 10:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2012-10-10 17:00 PDT, arno.
no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2012-10-10 17:04 PDT, arno.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2012-10-10 16:53:38 PDT
Hi,
in bug #91897,
if (bytesPerLine == targetRect.width() * bytesPerPixel
has been replaced by
 if (bytesPerLine == targetRect.width() / 4
(multiplication => division)

So, the "fast path" is never used anymore
Comment 1 arno. 2012-10-10 17:00:01 PDT
Created attachment 168098 [details]
Patch

patch proposal
Comment 2 WebKit Review Bot 2012-10-10 17:02:03 PDT
Attachment 168098 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 arno. 2012-10-10 17:04:29 PDT
Created attachment 168101 [details]
Patch

amended patch
Comment 4 WebKit Review Bot 2012-10-10 21:57:56 PDT
Comment on attachment 168101 [details]
Patch

Rejecting attachment 168101 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e-webkit line 164.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9
BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14257387
Comment 5 arno. 2012-10-11 09:55:46 PDT
(In reply to comment #4)
> (From update of attachment 168101 [details])
> Rejecting attachment 168101 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
> e-webkit line 164.
> 
> Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9
> BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
> 
> When you have resolved this problem run "git rebase --continue".
> If you would prefer to skip this patch, instead run "git rebase --skip".
> To restore the original branch and stop rebasing run "git rebase --abort".
> 
> rebase refs/remotes/origin/master: command returned error: 1
> 
> Died at Tools/Scripts/update-webkit line 164.
> 
> Full output: http://queues.webkit.org/results/14257387

I don't really understand why the patch could not be applied
Comment 6 Jocelyn Turcotte 2012-10-11 10:23:19 PDT
Comment on attachment 168101 [details]
Patch

Not sure either, the error seems unrelated.
Trying again.
Comment 7 WebKit Review Bot 2012-10-11 10:28:01 PDT
Comment on attachment 168101 [details]
Patch

Clearing flags on attachment: 168101

Committed r131078: <http://trac.webkit.org/changeset/131078>
Comment 8 WebKit Review Bot 2012-10-11 10:28:04 PDT
All reviewed patches have been landed.  Closing bug.