Bug 98968 - REGRESSION: Unable to scroll with trackpad on some websites after r130783
Summary: REGRESSION: Unable to scroll with trackpad on some websites after r130783
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2012-10-10 16:40 PDT by Beth Dakin
Modified: 2012-10-10 18:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2012-10-10 16:53 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-10-10 16:40:54 PDT 
http://trac.webkit.org/changeset/130783 broke scrolling on some internal Apple websites. The bug also affects bugs.webkit.org for me sometimes. Unfortunately, I do not have a reduced test case because the bug fails to reproduce when you save sites locally. 

<rdar://problem/12471825>

Patch forthcoming.
Comment 1 Beth Dakin 2012-10-10 16:53:14 PDT 
Created attachment 168095 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-10-10 18:00:27 PDT 
Comment on attachment 168095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168095&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:85
> +    m_changedProperties = ViewportRect | ContentsSize | NonFastScrollableRegion | WheelEventHandlerCount
> +        | ShouldUpdateScrollLayerPositionOnMainThread | HorizontalScrollElasticity | VerticalScrollElasticity
> +        | HasEnabledHorizontalScrollbar | HasEnabledVerticalScrollbar | HorizontalScrollbarMode
> +        | VerticalScrollbarMode | ScrollOrigin | RequestedScrollPosition;

Would be nicer if the enum had an 'All' value that was 0xFF or the OR of all the values.
Comment 3 Beth Dakin 2012-10-10 18:25:11 PDT 
Thanks Simon! I added an All value.

http://trac.webkit.org/changeset/130989