Bug 98961 – text-combine doesn’t use third- and quarter-width variants when used with @font-face

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

<rdar://problem/12472460>

When used with a @font-face font, text-combine fails to measure text using the third- and quarter-width variants, and renders with a different font altogether. Patch forthcoming.

Created attachment 168085 [details]
Patch

[WebKit Review Bot]

Attachment 168085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/platform/graphics/FontWidthVariant.h:41:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 168085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168085&action=review

> LayoutTests/fast/text/text-combine-with-font-face.html:4
> +        src: local(HiraMinProN-W3);

Is this one of the fonts we ship in the repo?

(In reply to comment #3)
> (From update of attachment 168085 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168085&action=review
> 
> > LayoutTests/fast/text/text-combine-with-font-face.html:4
> > +        src: local(HiraMinProN-W3);
> 
> Is this one of the fonts we ship in the repo?

No. local() means that a locally-installed font with that name should be used. OS X comes with that font.

Thanks for the review!

Fixed in <http://trac.webkit.org/r131005>.