Bug 98959 - check-layout.js should always dumpAsText
Summary: check-layout.js should always dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 15:28 PDT by Ojan Vafai
Modified: 2012-10-10 16:42 PDT (History)
1 user (show)

See Also:

Attachments
Patch (43.50 KB, patch)
2012-10-10 15:30 PDT, Ojan Vafai 		tony: review+
tony: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-10-10 15:28:10 PDT 
check-layout.js should always dumpAsText
Comment 1 Ojan Vafai 2012-10-10 15:30:52 PDT 
Created attachment 168079 [details]
Patch
Comment 2 Tony Chang 2012-10-10 16:36:49 PDT 
Comment on attachment 168079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168079&action=review

> LayoutTests/css3/flexbox/flex-item-child-overflow.html:-27
> -<div data-expected-height=0 class="flexbox">
> -    <div data-expected-height=0>
> -        <div data-offset-y=0 data-expected-height=20></div>

I would convert this to not be a ref-test since we do want to verify that the parent boxes have 0 height.
Comment 3 Ojan Vafai 2012-10-10 16:42:28 PDT 
Committed r130979: <http://trac.webkit.org/changeset/130979>