RESOLVED FIXED 98953
Import W3C test suite for performance.now()
https://bugs.webkit.org/show_bug.cgi?id=98953
Summary Import W3C test suite for performance.now()
James Simonsen
Reported 2012-10-10 13:37:04 PDT
There's an official W3C test suite for High Resolution Time. We should import that like we import the Navigation Timing test suite. It'll fail until we unprefix webkitNow().
Attachments
Patch (14.32 KB, patch)
2012-10-10 17:03 PDT, James Simonsen
no flags
Patch for landing (14.25 KB, patch)
2012-10-10 19:46 PDT, James Simonsen
no flags
James Simonsen
Comment 1 2012-10-10 17:03:46 PDT
James Simonsen
Comment 2 2012-10-10 17:05:15 PDT
This is ready for review. The script imported this without modification. I collected the -expected files by applying all of my pending patches and running it. It looks like we'll pass once everything lands.
Tony Gentilcore
Comment 3 2012-10-10 17:52:29 PDT
Comment on attachment 168099 [details] Patch Don't you need to skip it for platform/mac and platform/win as well?
James Simonsen
Comment 4 2012-10-10 18:10:16 PDT
(In reply to comment #3) > (From update of attachment 168099 [details]) > Don't you need to skip it for platform/mac and platform/win as well? No, they already skip the entire w3c directory because they don't enable WEB_TIMING.
WebKit Review Bot
Comment 5 2012-10-10 19:28:00 PDT
Comment on attachment 168099 [details] Patch Rejecting attachment 168099 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ile LayoutTests/platform/efl/TestExpectations.rej patching file LayoutTests/platform/gtk/TestExpectations Hunk #1 succeeded at 1380 with fuzz 2 (offset 9 lines). patching file LayoutTests/platform/qt/TestExpectations Hunk #1 FAILED at 2856. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Tony Genti..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14255404
James Simonsen
Comment 6 2012-10-10 19:46:49 PDT
Created attachment 168128 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-10-10 20:39:49 PDT
Comment on attachment 168128 [details] Patch for landing Clearing flags on attachment: 168128 Committed r131006: <http://trac.webkit.org/changeset/131006>
WebKit Review Bot
Comment 8 2012-10-10 20:39:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.