RESOLVED FIXED98952
Switch over CachedResource::data() from taking a SharedBuffer to taking a ResourceBuffer 
https://bugs.webkit.org/show_bug.cgi?id=98952
Summary Switch over CachedResource::data() from taking a SharedBuffer to taking a Res...
Brady Eidson
Reported 2012-10-10 13:27:56 PDT
Switch over CachedResource::data() from taking a SharedBuffer to taking a ResourceBuffer This is further progress towards http://bugs.webkit.org/show_bug.cgi?id=98539
Attachments
Patch v1 (19.06 KB, patch)
2012-10-10 16:09 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 - Now with more alphabetization (19.05 KB, patch)
2012-10-10 16:19 PDT, Brady Eidson 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-10 13:28:08 PDT
Patch coming soon.
Brady Eidson
Comment 2 2012-10-10 16:09:14 PDT
Created attachment 168084 [details] Patch v1
WebKit Review Bot
Comment 3 2012-10-10 16:12:28 PDT
Attachment 168084 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/html/ImageDocument.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2012-10-10 16:19:30 PDT
Created attachment 168088 [details] Patch v2 - Now with more alphabetization
Brady Eidson
Comment 5 2012-10-10 17:04:22 PDT
I'm going to land without the okay of cr-linux as it seems to be way behind, and I have no reason to believe this patch would break it without having broken any other port.
Brady Eidson
Comment 6 2012-10-10 17:26:45 PDT
http://trac.webkit.org/changeset/130983
Note You need to log in before you can comment on or make changes to this bug.