Bug 98949 – IndexedDB: setTimeout in layout tests causes flakiness in multiprocess ports

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: setTimeout in layout tests causes flakiness in multiprocess ports

[Joshua Bell]

Created attachment 168059 [details]
Patch

[Joshua Bell]

NOTE: WIP - intversion-close-between-events.html hasn't been fixed yet. It's unclear if that test is really testing anything distinct from intversion-close-in-oncomplete.html and intversion-close-in-upgradeneeded.html other than the race condition.

[Joshua Bell]

Created attachment 168806 [details]
Patch

[Joshua Bell]

dgrogan@ - please take a look?

[David Grogan]

Comment on attachment 168806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168806&action=review

LGTM

Thanks for fixing these

> LayoutTests/storage/indexeddb/resources/intversion-close-between-events.js:66
> +    if (!didCallCloseDB) {

We should probably test the other order also, if didCallCloseDB then evalAndExpectException("db.transaction(...)").

[Joshua Bell]

Created attachment 168812 [details]
Patch

[Joshua Bell]

Comment on attachment 168812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168812&action=review

> LayoutTests/fast/js/resources/js-test-pre.js:148
> +function evalAndLog(_a, _quiet)

The _quiet is so that if the text being eval'd is something like "quiet += 1" it doesn't collide.

(Maybe we should change these functions to use an indirect eval?)

> LayoutTests/fast/js/resources/js-test-pre.js:-530
> -                

This was actually a line full of space characters. I just deleted the line rather than fight with my editor that likes to delete trailing whitespace.

> LayoutTests/storage/indexeddb/mozilla/resources/create-index-unique.js:-41
> -    index = evalAndLog("index = objectStore.createIndex(indexName, indexKeyPath, { unique: true });", "IDBDatabaseException.CONSTRAINT_ERR");

Bogus second argument now being treated as |quiet|. I couldn't find any other examples in layout tests, but may have missed some.

[Joshua Bell]

tony@ - r?

[WebKit Review Bot]

Comment on attachment 168812 [details]
Patch

Clearing flags on attachment: 168812

Committed r131466: <http://trac.webkit.org/changeset/131466>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.