Bug 98923 – Web Inspector: Enabling experiments tab in WebKit nightly.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mihai Balan]

As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector.

[Mihai Balan]

(In reply to comment #0)
> As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector.

The initial wording is actually wrong. This patch is about enabling the experimental tab in WebKit nightly (not having it depend on a runtime flag - as is the case in Chromium)

[Mihai Balan]

Created attachment 168224 [details]
Patch for always enabling the experiments tab.

[Alexander Pavlov (apavlov)]

Comment on attachment 168224 [details]
Patch for always enabling the experiments tab.

View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review

So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases?

> Source/WebCore/inspector/front-end/Settings.js:220
> +        // to enable it at runtime

Lost closing parenthesis :)

[Mihai Balan]

(In reply to comment #3)
> (From update of attachment 168224 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review
> 
> So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases?
> 

This is my understanding from the discussion on webkit-dev [1] and the one on IRC today.

[1] http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html

[Pavel Feldman]

Comment on attachment 168224 [details]
Patch for always enabling the experiments tab.

This will also enable experiments in Chrome. You should instead add Preferences.experimentsEnabled and make it "true" in WebCore/inspector/front-end/Settings.js and "false" in WebKit/chromium/src/js/DevTools.js. This check will become Preferences.experimentsEnabled || "experiments" in WebInspector.queryParamsObject. I think it is fine to enable experiments on stable versions given that Safari ships its proprietary front-end now.

[Mihai Balan]

Created attachment 168238 [details]
Patch for enabling the experiments tab in WebKit nightly

[WebKit Review Bot]

Comment on attachment 168238 [details]
Patch for enabling the experiments tab in WebKit nightly

Clearing flags on attachment: 168238

Committed r131071: <http://trac.webkit.org/changeset/131071>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.