Bug 98891 - [WK2] should enable tests that use setAlwaysAcceptCookies()
Summary: [WK2] should enable tests that use setAlwaysAcceptCookies()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jussi Kukkonen (jku)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 05:51 PDT by Jussi Kukkonen (jku)
Modified: 2012-10-11 04:54 PDT (History)
1 user (show)

See Also:

Attachments
patch for cq (2.11 KB, patch)
2012-10-11 00:19 PDT, Jussi Kukkonen (jku) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen (jku) 2012-10-10 05:51:51 PDT 
There's a bunch of tests in wk2/TestExpectations with comment "WebKit2 needs layoutTestController.setAlwaysAcceptCookies". TestRunner has had that functionality for some months now, so the tests should be enabled (barring other problems).
Comment 1 Jussi Kukkonen (jku) 2012-10-11 00:19:52 PDT 
Created attachment 168152 [details]
patch for cq
Comment 2 Jussi Kukkonen (jku) 2012-10-11 02:39:07 PDT 
Comment on attachment 168152 [details]
patch for cq

Nice surprise, nothing had broken during the time these were skipped (although many tests are already skipped in port specific TestExpectations, but that's fine). 

commit-queue, please?
Comment 3 WebKit Review Bot 2012-10-11 04:54:42 PDT 
Comment on attachment 168152 [details]
patch for cq

Clearing flags on attachment: 168152

Committed r131044: <http://trac.webkit.org/changeset/131044>
Comment 4 WebKit Review Bot 2012-10-11 04:54:45 PDT 
All reviewed patches have been landed.  Closing bug.