Bug 98883 - [EFL][WK2] Add toolbar buttons to MiniBrowser
Summary: [EFL][WK2] Add toolbar buttons to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 98748
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-10 03:55 PDT by Chris Dumez
Modified: 2012-10-10 16:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.79 KB, patch)
2012-10-10 10:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Screenshot (43.29 KB, image/png)
2012-10-10 10:48 PDT, Chris Dumez 		no flags Details
Patch (13.79 KB, patch)
2012-10-10 11:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.79 KB, patch)
2012-10-10 11:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.80 KB, patch)
2012-10-10 11:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-10 03:55:49 PDT 
It would be nice to add a "back" button to MiniBrowser.
Comment 1 Chris Dumez 2012-10-10 10:47:51 PDT 
Created attachment 168031 [details]
Patch
Comment 2 Chris Dumez 2012-10-10 10:48:18 PDT 
Created attachment 168032 [details]
Screenshot
Comment 3 Chris Dumez 2012-10-10 11:01:48 PDT 
Created attachment 168037 [details]
Patch

Warning fix.
Comment 4 Chris Dumez 2012-10-10 11:08:08 PDT 
Created attachment 168038 [details]
Patch

Fixed a few typos.
Comment 5 Chris Dumez 2012-10-10 11:12:36 PDT 
Created attachment 168040 [details]
Patch
Comment 6 Kenneth Rohde Christiansen 2012-10-10 14:35:09 PDT 
Comment on attachment 168040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168040&action=review

> Source/WebKit2/ChangeLog:8
> +        Add "back,forward,list,changed" signal on the Ewk_View

Now we are talking!

> Tools/MiniBrowser/efl/main.c:217
> +    /* Update navigation buttons state */

EFL supports // comments now :-) Apparently Rasterman accepted that!
Comment 7 WebKit Review Bot 2012-10-10 16:36:17 PDT 
Comment on attachment 168040 [details]
Patch

Clearing flags on attachment: 168040

Committed r130978: <http://trac.webkit.org/changeset/130978>
Comment 8 WebKit Review Bot 2012-10-10 16:36:21 PDT 
All reviewed patches have been landed.  Closing bug.