Bug 98880 - [Qt]QtTestBrowser should have default url(google.com) when no command line args
Summary: [Qt]QtTestBrowser should have default url(google.com) when no command line args
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 03:39 PDT by Vivek Galatage
Modified: 2012-10-10 05:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2012-10-10 04:00 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-10-10 03:39:01 PDT 
[Qt]QtTestBrowser should have default url(google.com) when no command line args
Comment 1 Vivek Galatage 2012-10-10 04:00:15 PDT 
Created attachment 167974 [details]
Patch
Comment 2 Vivek Galatage 2012-10-10 04:18:37 PDT 
Ossy: Since today, I have shifted to using git for webkit development. Hence wanted to see how the webkit-patch script would work with git. Hence created and submitted this patch. And thank you for seconding the idea of using the url as default.
Comment 3 WebKit Review Bot 2012-10-10 04:51:50 PDT 
Comment on attachment 167974 [details]
Patch

Rejecting attachment 167974 [details] from commit-queue.

New failing tests:
fast/frames/frame-limit.html
Full output: http://queues.webkit.org/results/14249340
Comment 4 WebKit Review Bot 2012-10-10 05:33:26 PDT 
Comment on attachment 167974 [details]
Patch

Clearing flags on attachment: 167974

Committed r130890: <http://trac.webkit.org/changeset/130890>
Comment 5 WebKit Review Bot 2012-10-10 05:33:29 PDT 
All reviewed patches have been landed.  Closing bug.