Bug 98877 - FontVerticalDataCache should allow zero as a key value
Summary: FontVerticalDataCache should allow zero as a key value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 01:10 PDT by Kenichi Ishibashi
Modified: 2012-10-10 15:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2012-10-10 01:15 PDT, Kenichi Ishibashi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-10-10 01:10:00 PDT 
It seems that FontPlatformDataHarfBuzz::uniqueID() can be zero for valid instance. Since FontPlatformDataHarfBuzz::uniqueID() is used for a key of FontVerticalDataCache in some ports (chromium linux, android, blackberry), the cache should accept zero as a key value.
Comment 1 Kenichi Ishibashi 2012-10-10 01:15:59 PDT 
Created attachment 167954 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-10-10 01:29:13 PDT 
Hi Tony,

Could you take a look?
Comment 3 Kenichi Ishibashi 2012-10-10 15:11:03 PDT 
Comment on attachment 167954 [details]
Patch

Thanks!
Comment 4 WebKit Review Bot 2012-10-10 15:17:16 PDT 
Comment on attachment 167954 [details]
Patch

Clearing flags on attachment: 167954

Committed r130968: <http://trac.webkit.org/changeset/130968>
Comment 5 WebKit Review Bot 2012-10-10 15:17:19 PDT 
All reviewed patches have been landed.  Closing bug.