RESOLVED FIXED 98864
REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot 
https://bugs.webkit.org/show_bug.cgi?id=98864
Summary REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
Carlos Garcia Campos
Reported 2012-10-09 23:24:39 PDT
r130755 added a resource bundle that is loaded when tests start. We need to copy that bundle file too to make unit tests work again.
Attachments
Patch (4.75 KB, patch)
2012-10-26 17:24 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2012-10-29 15:03 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Pena
Comment 1 2012-10-17 00:58:54 PDT
I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive. The current "neededDirectories" are "Programs", ".libs", "Libraries" and "TestNetscapePlugin", and I don't think the gresource bundle fits in any of them. On the other hand, it doesn't seem right to add DerivedSources/WebKit2 as a "neededDirectory", so maybe we could generate the bundle into some new location and add that new location as an exception.
Sergio Villar Senin
Comment 2 2012-10-26 17:16:08 PDT
(In reply to comment #1) > I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive. > So I agree with this. I think the best option is to generate the resource under DerivedSources/WebKit2/resources and then just add it to the list of dirs to export.
Sergio Villar Senin
Comment 3 2012-10-26 17:24:12 PDT
Created attachment 171059 [details] Patch
WebKit Review Bot
Comment 4 2012-10-26 17:25:56 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 5 2012-10-26 22:41:02 PDT
Comment on attachment 171059 [details] Patch Hrm. I don't think that DerivedSources is the right place to generate this the GResource file anyway. It should probably be generated into Programs/resources. DerivedSources is a place to put pre-compilation generated source code, not build products.
Sergio Villar Senin
Comment 6 2012-10-29 15:03:27 PDT
Created attachment 171317 [details] Patch
Martin Robinson
Comment 7 2012-10-29 16:34:52 PDT
Comment on attachment 171317 [details] Patch Great! Thanks.
Sergio Villar Senin
Comment 8 2012-10-29 20:42:40 PDT
Comment on attachment 171317 [details] Patch Clearing flags on attachment: 171317 Committed r132870: <http://trac.webkit.org/changeset/132870>
Sergio Villar Senin
Comment 9 2012-10-29 20:42:44 PDT
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 10 2012-10-30 00:36:04 PDT
Thank you guys!
Note You need to log in before you can comment on or make changes to this bug.