Bug 98864 - REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
Summary: REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-10-09 23:24 PDT by Carlos Garcia Campos
Modified: 2012-10-30 00:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.75 KB, patch)
2012-10-26 17:24 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2012-10-29 15:03 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-10-09 23:24:39 PDT
r130755 added a resource bundle that is loaded when tests start. We need to copy that bundle file too to make unit tests work again.
Comment 1 Simon Pena 2012-10-17 00:58:54 PDT
I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive.

The current "neededDirectories" are "Programs", ".libs", "Libraries" and "TestNetscapePlugin", and I don't think the gresource bundle fits in any of them. On the other hand, it doesn't seem right to add DerivedSources/WebKit2 as a "neededDirectory", so maybe we could generate the bundle into some new location and add that new location as an exception.
Comment 2 Sergio Villar Senin 2012-10-26 17:16:08 PDT
(In reply to comment #1)
> I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive.
> 

So I agree with this. I think the best option is to generate the resource under DerivedSources/WebKit2/resources and then just add it to the list of dirs to export.
Comment 3 Sergio Villar Senin 2012-10-26 17:24:12 PDT
Created attachment 171059 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-26 17:25:56 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 Martin Robinson 2012-10-26 22:41:02 PDT
Comment on attachment 171059 [details]
Patch

Hrm. I don't think that DerivedSources is the right place to generate this the GResource file anyway. It should probably be generated into Programs/resources.  DerivedSources is a place to put pre-compilation generated source code, not build products.
Comment 6 Sergio Villar Senin 2012-10-29 15:03:27 PDT
Created attachment 171317 [details]
Patch
Comment 7 Martin Robinson 2012-10-29 16:34:52 PDT
Comment on attachment 171317 [details]
Patch

Great! Thanks.
Comment 8 Sergio Villar Senin 2012-10-29 20:42:40 PDT
Comment on attachment 171317 [details]
Patch

Clearing flags on attachment: 171317

Committed r132870: <http://trac.webkit.org/changeset/132870>
Comment 9 Sergio Villar Senin 2012-10-29 20:42:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Carlos Garcia Campos 2012-10-30 00:36:04 PDT
Thank you guys!