Bug 98855 - Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerARM
Summary: Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 98605
  Show dependency tree / graph
 
Reported: 2012-10-09 22:03 PDT by Csaba Osztrogonác
Modified: 2012-10-10 01:31 PDT (History)
10 users (show)

See Also:

Attachments
speculative fix (1.71 KB, patch)
2012-10-10 00:53 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-09 22:03:29 PDT 
http://trac.webkit.org/changeset/130839 broke the Qt ARM
build, because 2 new functions introduced in it:
- moveDoubleToInts
- moveIntsToDouble

But their implementation in ARMAssembler is still missing.
Comment 1 Peter Gal 2012-10-10 00:53:06 PDT 
Created attachment 167946 [details]
speculative fix

very speculative fix.
Comment 2 Filip Pizlo 2012-10-10 01:14:07 PDT 
Comment on attachment 167946 [details]
speculative fix

This looks right.  R=me.
Comment 3 WebKit Review Bot 2012-10-10 01:31:37 PDT 
Comment on attachment 167946 [details]
speculative fix

Clearing flags on attachment: 167946

Committed r130872: <http://trac.webkit.org/changeset/130872>
Comment 4 WebKit Review Bot 2012-10-10 01:31:41 PDT 
All reviewed patches have been landed.  Closing bug.