WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98852
[EFL] Add background color to the radio button theme.
https://bugs.webkit.org/show_bug.cgi?id=98852
Summary
[EFL] Add background color to the radio button theme.
Byungwoo Lee
Reported
2012-10-09 21:30:43 PDT
Need to modify theme.
Attachments
Patch
(4.76 KB, patch)
2012-10-15 04:12 PDT
,
Byungwoo Lee
no flags
Details
Formatted Diff
Diff
test radio button status with white and black background.
(555 bytes, text/html)
2012-10-15 05:37 PDT
,
Byungwoo Lee
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Byungwoo Lee
Comment 1
2012-10-15 04:12:45 PDT
Created
attachment 168673
[details]
Patch
Byungwoo Lee
Comment 2
2012-10-15 05:37:52 PDT
Created
attachment 168690
[details]
test radio button status with white and black background.
Eric Seidel (no email)
Comment 3
2012-10-15 13:06:08 PDT
Attachment 168673
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png:0: Have to enable auto props in the subversion config file (/Users/eseidel/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/Users/eseidel/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Byungwoo Lee
Comment 4
2012-10-16 22:35:45 PDT
(In reply to
comment #3
)
>
Attachment 168673
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 > Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png:0: Have to enable auto props in the subversion config file (/Users/eseidel/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/Users/eseidel/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
This looks a problem of the style-bot. (The style-bot need to set some features for svn to ~/.subversion/config file)
WebKit Review Bot
Comment 5
2012-10-17 00:05:50 PDT
Comment on
attachment 168673
[details]
Patch Clearing flags on attachment: 168673 Committed
r131554
: <
http://trac.webkit.org/changeset/131554
>
WebKit Review Bot
Comment 6
2012-10-17 00:05:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug