Bug 98839 - Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
Summary: Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 18:04 PDT by Simon Fraser (smfr)
Modified: 2012-10-15 21:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (19.19 KB, patch)
2012-10-09 18:11 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (20.88 KB, patch)
2012-10-10 09:45 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (20.87 KB, patch)
2012-10-10 09:46 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (20.90 KB, patch)
2012-10-10 10:01 PDT, Simon Fraser (smfr)
sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-09 18:04:58 PDT
Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
Comment 1 Simon Fraser (smfr) 2012-10-09 18:11:31 PDT
Created attachment 167890 [details]
Patch
Comment 2 Build Bot 2012-10-09 19:29:46 PDT
Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14250146
Comment 3 Early Warning System Bot 2012-10-09 19:44:48 PDT
Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14215982
Comment 4 Early Warning System Bot 2012-10-09 20:16:57 PDT
Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14245339
Comment 5 Gyuyoung Kim 2012-10-09 20:23:25 PDT
Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14250158
Comment 6 Sam Weinig 2012-10-09 21:20:56 PDT
Comment on attachment 167890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167890&action=review

Looks good, but more things need to build.

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:695
> +    WTF::String output = layer->layerTreeAsText(LayerTreeAsTextDebug | LayerTreeAsTextIncludeVisibleRects);

Not new, but the WTF:: here is not necessary.

> Source/WebCore/platform/graphics/GraphicsLayer.h:439
> +    static void writeIndent(TextStream&, int /*indent*/);

There is no reason to comment out the word indent here.
Comment 7 Simon Fraser (smfr) 2012-10-10 09:45:25 PDT
Created attachment 168016 [details]
Patch
Comment 8 Simon Fraser (smfr) 2012-10-10 09:46:45 PDT
Created attachment 168017 [details]
Patch
Comment 9 Gyuyoung Kim 2012-10-10 10:00:52 PDT
Comment on attachment 168017 [details]
Patch

Attachment 168017 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14254221
Comment 10 Simon Fraser (smfr) 2012-10-10 10:01:02 PDT
Created attachment 168021 [details]
Patch
Comment 11 Build Bot 2012-10-10 10:27:09 PDT
Comment on attachment 168021 [details]
Patch

Attachment 168021 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14245581
Comment 12 kov's GTK+ EWS bot 2012-10-10 10:50:04 PDT
Comment on attachment 168021 [details]
Patch

Attachment 168021 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14260089
Comment 13 Simon Fraser (smfr) 2012-10-10 10:50:58 PDT
http://trac.webkit.org/changeset/130927

This will break the Windows build with a link error, which I'll use to get the right mangled symbol to export.