Bug 98839 – Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText

[Simon Fraser (smfr)]

Created attachment 167890 [details]
Patch

[Build Bot]

Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14250146

[Early Warning System Bot]

Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14215982

[Early Warning System Bot]

Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14245339

[Gyuyoung Kim]

Comment on attachment 167890 [details]
Patch

Attachment 167890 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14250158

[Sam Weinig]

Comment on attachment 167890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167890&action=review

Looks good, but more things need to build.

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:695
> +    WTF::String output = layer->layerTreeAsText(LayerTreeAsTextDebug | LayerTreeAsTextIncludeVisibleRects);

Not new, but the WTF:: here is not necessary.

> Source/WebCore/platform/graphics/GraphicsLayer.h:439
> +    static void writeIndent(TextStream&, int /*indent*/);

There is no reason to comment out the word indent here.

[Simon Fraser (smfr)]

Created attachment 168016 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 168017 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 168017 [details]
Patch

Attachment 168017 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14254221

[Simon Fraser (smfr)]

Created attachment 168021 [details]
Patch

[Build Bot]

Comment on attachment 168021 [details]
Patch

Attachment 168021 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14245581

[kov's GTK+ EWS bot]

Comment on attachment 168021 [details]
Patch

Attachment 168021 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14260089

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/130927

This will break the Windows build with a link error, which I'll use to get the right mangled symbol to export.