Bug 98819 - [BlackBerry] Define WTF_USE_EXPORT_MACROS in cmake rather than Platform.h
Summary: [BlackBerry] Define WTF_USE_EXPORT_MACROS in cmake rather than Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 13:18 PDT by Yong Li
Modified: 2012-10-10 11:12 PDT (History)
7 users (show)

See Also:

Attachments
the patch (2.27 KB, patch)
2012-10-09 13:55 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-10-09 13:18:53 PDT 
Define WTF_USE_EXTRA_MACROS in cmake rather than Platform.h, and make it depend on SHARED_CORE
Comment 1 Yong Li 2012-10-09 13:55:14 PDT 
Created attachment 167842 [details]
the patch
Comment 2 Laszlo Gombos 2012-10-09 18:29:19 PDT 
As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. 

Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h).

Related discussion at bug 97250.
Comment 3 Yong Li 2012-10-10 07:38:25 PDT 
(In reply to comment #2)
> As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. 
> 
> Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h).
> 
> Related discussion at bug 97250.

Thanks for the info. For some stable macros (using JIT or some features), probably it is better to define them in the .h file. But I feel this symbol exporting stuff should better be decided by the build system
Comment 4 Rob Buis 2012-10-10 08:23:40 PDT 
Comment on attachment 167842 [details]
the patch

Looks good.
Comment 5 WebKit Review Bot 2012-10-10 08:48:41 PDT 
Comment on attachment 167842 [details]
the patch

Clearing flags on attachment: 167842

Committed r130909: <http://trac.webkit.org/changeset/130909>
Comment 6 WebKit Review Bot 2012-10-10 08:48:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Yong Li 2012-10-10 11:12:52 PDT 
Oops, just found a typo in the title...