Bug 98805 - Add tests to testapi for null OpaqueJSStrings
Summary: Add tests to testapi for null OpaqueJSStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 98300
  Show dependency treegraph
 
Reported: 2012-10-09 11:36 PDT by Michael Saboff
Modified: 2012-10-09 18:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2012-10-09 12:49 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-09 11:36:54 PDT
There isn't sufficient testing for the handling of null OpaqueJSStrings.  This is evident from the changes to OpaqueJSString in r130344 from https://bugs.webkit.org/show_bug.cgi?id=98300 and its follow-ons.
Comment 1 Michael Saboff 2012-10-09 12:49:53 PDT
Created attachment 167824 [details]
Patch
Comment 2 Geoffrey Garen 2012-10-09 17:52:10 PDT
Comment on attachment 167824 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2012-10-09 18:18:53 PDT
Comment on attachment 167824 [details]
Patch

Clearing flags on attachment: 167824

Committed r130832: <http://trac.webkit.org/changeset/130832>
Comment 4 WebKit Review Bot 2012-10-09 18:18:56 PDT
All reviewed patches have been landed.  Closing bug.