Bug 9880 - Memory leaks running DOM-Hanoi
Summary: Memory leaks running DOM-Hanoi
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
URL: http://metasploit.com/users/hdm/tools...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-12 11:45 PDT by Alexey Proskuryakov
Modified: 2006-07-13 08:49 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (766 bytes, patch)
2006-07-12 11:47 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-07-12 11:45:35 PDT
Technically, these are not leaks, but the effect is similar :)

When running certain non-stop browser tests, such as DOM-Hanoi (see bug URL), Safari memory usage grows fast, because Obj-C autoreleased objects do not get a chance to be collected. I suspect they may fill the address space before the test actually finishes, but I was not patient enough to stand the paging.

All such allocations are made inside FrameMac::setStatusBarText(), so I gave this method an autorelease pool of its own.
Comment 1 Alexey Proskuryakov 2006-07-12 11:47:22 PDT
Created attachment 9409 [details]
proposed patch
Comment 2 Darin Adler 2006-07-12 14:25:31 PDT
Comment on attachment 9409 [details]
proposed patch

Looks good. r=me

But are there any other calls besides "set status bar text" that need an autorelease pool for the same reason?
Comment 3 Alexey Proskuryakov 2006-07-12 21:17:21 PDT
(In reply to comment #2)
> But are there any other calls besides "set status bar text" that need an
> autorelease pool for the same reason?

This patch fixes all DOM-Hanoi "leaks". Perhaps, other tests will uncover more?
Comment 4 David Kilzer (:ddkilzer) 2006-07-12 21:23:17 PDT
Darin, should this patch be committed now, or should it wait until after the stabilization period?
Comment 5 Darin Adler 2006-07-12 21:43:40 PDT
(In reply to comment #4)
> Darin, should this patch be committed now, or should it wait until after the
> stabilization period?

I think it's good to land this now.
Comment 6 Alexey Proskuryakov 2006-07-13 08:49:04 PDT
Committed revision 15405.