Bug 98790 - [EFL][WK2] Add APIs to get/set the DNS prefetching
Summary: [EFL][WK2] Add APIs to get/set the DNS prefetching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 10:13 PDT by Jinwoo Song
Modified: 2012-10-10 05:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2012-10-09 10:37 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2012-10-10 03:04 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-10-09 10:13:14 PDT
Add ewk_settings_enable_DNS_prefetching_get/set APIs to WebKit2/Efl.
Comment 1 Jinwoo Song 2012-10-09 10:37:09 PDT
Created attachment 167778 [details]
Patch
Comment 2 Laszlo Gombos 2012-10-09 21:12:30 PDT
Comment on attachment 167778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review

LGTM.

> Source/WebKit2/ChangeLog:8
> +        Added setting APIs for DNS prefetching and a unit test.

Added -> Add.
Comment 3 Chris Dumez 2012-10-09 21:57:35 PDT
Comment on attachment 167778 [details]
Patch

Sorry but this is missing unit tests. We should not land new APIs without unit tests.
Comment 4 Chris Dumez 2012-10-09 21:58:28 PDT
(In reply to comment #3)
> (From update of attachment 167778 [details])
> Sorry but this is missing unit tests. We should not land new APIs without unit tests.

arg... never mind me. There are unit tests :)
Go ahead then.
Comment 5 Gyuyoung Kim 2012-10-09 22:06:31 PDT
Comment on attachment 167778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
> + * @param settings settings object to get DNS prefetching.

We don't use '.' at @param.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
> +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));

We decided to use standard boolean in test case.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
> +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));

ditto.
Comment 6 Jinwoo Song 2012-10-10 03:01:45 PDT
(In reply to comment #2)
> (From update of attachment 167778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review
> 
> LGTM.
> 
> > Source/WebKit2/ChangeLog:8
> > +        Added setting APIs for DNS prefetching and a unit test.
> 
> Added -> Add.

Fixed.
Comment 7 Jinwoo Song 2012-10-10 03:02:02 PDT
(In reply to comment #5)
> (From update of attachment 167778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
> > + * @param settings settings object to get DNS prefetching.
> 
> We don't use '.' at @param.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
> > +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));
> 
> We decided to use standard boolean in test case.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
> > +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));
> 
> ditto.

Fixed.
Comment 8 Jinwoo Song 2012-10-10 03:04:13 PDT
Created attachment 167965 [details]
Patch
Comment 9 WebKit Review Bot 2012-10-10 03:41:22 PDT
Comment on attachment 167965 [details]
Patch

Clearing flags on attachment: 167965

Committed r130882: <http://trac.webkit.org/changeset/130882>
Comment 10 WebKit Review Bot 2012-10-10 03:41:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Raphael Kubo da Costa (:rakuco) 2012-10-10 05:09:56 PDT
Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs.
Comment 12 Jinwoo Song 2012-10-10 05:13:05 PDT
(In reply to comment #11)
> Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs.

I didn't catch that. Then I'll change it in https://bugs.webkit.org/show_bug.cgi?id=98793. Thanks. :)