RESOLVED FIXED 98790
[EFL][WK2] Add APIs to get/set the DNS prefetching 
https://bugs.webkit.org/show_bug.cgi?id=98790
Summary [EFL][WK2] Add APIs to get/set the DNS prefetching
Jinwoo Song
Reported 2012-10-09 10:13:14 PDT
Add ewk_settings_enable_DNS_prefetching_get/set APIs to WebKit2/Efl.
Attachments
Patch (4.44 KB, patch)
2012-10-09 10:37 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (4.42 KB, patch)
2012-10-10 03:04 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-10-09 10:37:09 PDT
Created attachment 167778 [details] Patch
Laszlo Gombos
Comment 2 2012-10-09 21:12:30 PDT
Comment on attachment 167778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review LGTM. > Source/WebKit2/ChangeLog:8 > + Added setting APIs for DNS prefetching and a unit test. Added -> Add.
Chris Dumez
Comment 3 2012-10-09 21:57:35 PDT
Comment on attachment 167778 [details] Patch Sorry but this is missing unit tests. We should not land new APIs without unit tests.
Chris Dumez
Comment 4 2012-10-09 21:58:28 PDT
(In reply to comment #3) > (From update of attachment 167778 [details]) > Sorry but this is missing unit tests. We should not land new APIs without unit tests. arg... never mind me. There are unit tests :) Go ahead then.
Gyuyoung Kim
Comment 5 2012-10-09 22:06:31 PDT
Comment on attachment 167778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206 > + * @param settings settings object to get DNS prefetching. We don't use '.' at @param. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154 > + ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE)); We decided to use standard boolean in test case. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157 > + ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE)); ditto.
Jinwoo Song
Comment 6 2012-10-10 03:01:45 PDT
(In reply to comment #2) > (From update of attachment 167778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review > > LGTM. > > > Source/WebKit2/ChangeLog:8 > > + Added setting APIs for DNS prefetching and a unit test. > > Added -> Add. Fixed.
Jinwoo Song
Comment 7 2012-10-10 03:02:02 PDT
(In reply to comment #5) > (From update of attachment 167778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206 > > + * @param settings settings object to get DNS prefetching. > > We don't use '.' at @param. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154 > > + ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE)); > > We decided to use standard boolean in test case. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157 > > + ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE)); > > ditto. Fixed.
Jinwoo Song
Comment 8 2012-10-10 03:04:13 PDT
Created attachment 167965 [details] Patch
WebKit Review Bot
Comment 9 2012-10-10 03:41:22 PDT
Comment on attachment 167965 [details] Patch Clearing flags on attachment: 167965 Committed r130882: <http://trac.webkit.org/changeset/130882>
WebKit Review Bot
Comment 10 2012-10-10 03:41:26 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 11 2012-10-10 05:09:56 PDT
Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs.
Jinwoo Song
Comment 12 2012-10-10 05:13:05 PDT
(In reply to comment #11) > Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs. I didn't catch that. Then I'll change it in https://bugs.webkit.org/show_bug.cgi?id=98793. Thanks. :)
Note You need to log in before you can comment on or make changes to this bug.