RESOLVED FIXED 98757
[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden. 
https://bugs.webkit.org/show_bug.cgi?id=98757
Summary [EFL][WK2] Inform the PageProxy about visibility changes when the view is sho...
Raphael Kubo da Costa (:rakuco)
Reported 2012-10-09 07:42:33 PDT
[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.
Attachments
Patch (3.04 KB, patch)
2012-10-09 07:47 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2012-10-09 07:57 PDT, Raphael Kubo da Costa (:rakuco) 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-10-09 07:47:27 PDT
Created attachment 167755 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-09 07:49:16 PDT
Comment on attachment 167755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); hide -> view is visible?
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-10-09 07:52:40 PDT
(In reply to comment #2) > (From update of attachment 167755 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); > > hide -> view is visible? -ENOPARSE :-) There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns.
Kenneth Rohde Christiansen
Comment 4 2012-10-09 07:53:43 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 167755 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > > > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); > > > > hide -> view is visible? > > -ENOPARSE :-) > > There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns. Oh my, needs a comment anyway!
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-10-09 07:57:53 PDT
Created attachment 167757 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-10-09 08:03:47 PDT
Committed r130764: <http://trac.webkit.org/changeset/130764>
Note You need to log in before you can comment on or make changes to this bug.