Bug 98757 - [EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.
Summary: [EFL][WK2] Inform the PageProxy about visibility changes when the view is sho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 07:42 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-10-09 08:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2012-10-09 07:47 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2012-10-09 07:57 PDT, Raphael Kubo da Costa (:rakuco) 		kenneth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-10-09 07:42:33 PDT 
[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-10-09 07:47:27 PDT 
Created attachment 167755 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-09 07:49:16 PDT 
Comment on attachment 167755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);

hide -> view is visible?
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-10-09 07:52:40 PDT 
(In reply to comment #2)
> (From update of attachment 167755 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> > +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);
> 
> hide -> view is visible?

-ENOPARSE :-)

There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns.
Comment 4 Kenneth Rohde Christiansen 2012-10-09 07:53:43 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 167755 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> > > +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);
> > 
> > hide -> view is visible?
> 
> -ENOPARSE :-)
> 
> There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns.

Oh my, needs a comment anyway!
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-10-09 07:57:53 PDT 
Created attachment 167757 [details]
Patch
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-10-09 08:03:47 PDT 
Committed r130764: <http://trac.webkit.org/changeset/130764>