Bug 98753 - Change PeerConnection getStats function to single value local / remote
Summary: Change PeerConnection getStats function to single value local / remote
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-10-09 04:52 PDT by Harald Alvestrand
Modified: 2012-10-09 08:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (15.23 KB, patch)
2012-10-09 05:07 PDT, Harald Alvestrand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Alvestrand 2012-10-09 04:52:33 PDT 
As landed, PeerConnection draft spec says that the local and remote components of an RTCStatsReport are single RTCStatsElement attributes, not arrays of RTCStatselement (as an earlier draft said) or a function returning a sequence<RTCStatsElement> (as the patch landed).

This seems to make sense as a simplification.
Comment 1 Harald Alvestrand 2012-10-09 05:07:26 PDT 
Created attachment 167737 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-09 05:08:33 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-10-09 08:40:27 PDT 
Comment on attachment 167737 [details]
Patch

That's much simpler.
Comment 4 WebKit Review Bot 2012-10-09 08:56:04 PDT 
Comment on attachment 167737 [details]
Patch

Clearing flags on attachment: 167737

Committed r130768: <http://trac.webkit.org/changeset/130768>
Comment 5 WebKit Review Bot 2012-10-09 08:56:08 PDT 
All reviewed patches have been landed.  Closing bug.