Bug 98752 - [CSS Regions] Create a separate list for the invalid regions
Summary: [CSS Regions] Create a separate list for the invalid regions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2012-10-09 04:46 PDT by Andrei Bucur
Modified: 2012-10-10 10:11 PDT (History)
7 users (show)

See Also:

Attachments
Patch (35.81 KB, patch)
2012-10-09 08:53 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (33.41 KB, patch)
2012-10-10 01:36 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (36.61 KB, patch)
2012-10-10 05:18 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2012-10-09 04:46:54 PDT 
The regions that create dependency cycles between flows (invalid regions) and valid regions reside in the same list. This adds complexity to the code because iterations through the region list need to check the validity of the items. Getting the first/last valid region is also overly-complicated (the first/last invalid regions need to be skipped). There should be a separate low traffic list for the invalid regions that's used when dependencies between flow threads change.
Comment 1 Andrei Bucur 2012-10-09 08:53:22 PDT 
Created attachment 167765 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-09 09:45:41 PDT 
Comment on attachment 167765 [details]
Patch

Attachment 167765 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14248101

New failing tests:
fast/regions/flows-dependency-same-flow.html
fast/frames/frame-limit.html
Comment 3 Andrei Bucur 2012-10-10 01:36:49 PDT 
Created attachment 167958 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-10 03:41:11 PDT 
Comment on attachment 167958 [details]
Patch

Attachment 167958 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14229968

New failing tests:
fast/regions/flows-dependency-same-flow.html
Comment 5 Andrei Bucur 2012-10-10 05:18:07 PDT 
Created attachment 167983 [details]
Patch
Comment 6 Andreas Kling 2012-10-10 09:41:29 PDT 
Comment on attachment 167983 [details]
Patch

Love it! r=me
Comment 7 WebKit Review Bot 2012-10-10 10:11:10 PDT 
Comment on attachment 167983 [details]
Patch

Clearing flags on attachment: 167983

Committed r130918: <http://trac.webkit.org/changeset/130918>
Comment 8 WebKit Review Bot 2012-10-10 10:11:15 PDT 
All reviewed patches have been landed.  Closing bug.