Bug 98738 - REGRESSION (r130640 - r130644): TestCookieManager API test is failing
Summary: REGRESSION (r130640 - r130644): TestCookieManager API test is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2012-10-09 03:46 PDT by Zan Dobersek
Modified: 2012-10-19 02:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2012-10-19 02:10 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-10-09 03:46:34 PDT 
The TestCookieManager API test case is failing.

TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/WebKit2APITests/TestCookieManager... (pid=7994)

  /webkit2/WebKitCookieManager/accept-policy:                          **

ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp:181:void testCookieManagerAcceptPolicy(CookieManagerTest*, gconstpointer): assertion failed (domains[0] == kFirstPartyDomain): ("localhost" == "127.0.0.1")

FAIL

First occurrence on 64-bit Release builder, r130640-r130644:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/29516
First occurrence on 64-bit Debug builder, r130643-r130645:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/37403

Perhaps r130643 is to blame, I'm not sure though.
http://trac.webkit.org/changeset/130643
Comment 1 Zan Dobersek 2012-10-09 04:06:02 PDT 
Skipped the specific test case in r130748.
http://trac.webkit.org/changeset/130748
Comment 2 Carlos Garcia Campos 2012-10-19 02:10:20 PDT 
Created attachment 169580 [details]
Patch
Comment 3 WebKit Review Bot 2012-10-19 02:11:43 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2012-10-19 02:18:26 PDT 
Committed r131876: <http://trac.webkit.org/changeset/131876>