NEW98737
Change allowRoudingHack with setAllowRoudingHack 
https://bugs.webkit.org/show_bug.cgi?id=98737
Summary Change allowRoudingHack with setAllowRoudingHack
Gyuyoung Kim
Reported 2012-10-09 03:29:53 PDT
As Bug 87328 #20 mentioned, allowRoundingHack() needs to be changed with setAllowRoundingHack(bool) because allowRoundingHack() calls TextRun::setAllowsRoundingHacks(allowed). In addition, we don't need to keep allowRoundingHack() in Internals.cpp. allowRoundingHack() just calls internals's function.
Attachments
Patch (8.90 KB, patch)
2012-10-09 03:32 PDT, Gyuyoung Kim 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-10-09 03:32:22 PDT
Created attachment 167723 [details] Patch
Gyuyoung Kim
Comment 2 2012-10-09 03:35:50 PDT
Simon, could you take a look this ? BTW, I'm not sure if allowRoundingHack can be changed in this patch together. If you wanna change the name, IMO, it would be good if new bug deals with it. Because, setAllowRoundingHack / allowRoundingHack was made by mac port originally.
Simon Fraser (smfr)
Comment 3 2012-10-09 10:27:14 PDT
Comment on attachment 167723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167723&action=review > Source/WebCore/testing/InternalSettings.idl:77 > - void allowRoundingHacks(); > + void setAllowRoundingHacks(in boolean allowed); I think this should be called some thing like "setAllowTextRounding()" or something. The term "hacks" isn't useful here, and it need some context that suggests that it applies to text. Looking at TextRun, it appears to affect word and text run rounding.
Note You need to log in before you can comment on or make changes to this bug.