WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
98736
[EFL] duplicate entries in TestExpectations for 'efl' and 'wk2'
https://bugs.webkit.org/show_bug.cgi?id=98736
Summary
[EFL] duplicate entries in TestExpectations for 'efl' and 'wk2'
Jussi Kukkonen (jku)
Reported
2012-10-09 03:19:11 PDT
We have more port-specific expectations than we really need, that's not good: Quite a few of the efl failure expectation are listed because wk1 failed those tests. After that webkit2 bugs for the same (often totally missing) functionality have been filed and the failures have been listed in the wk2 TestExpectations. For all duplicate lines in wk2 and efl TestExpectations, I'm planning to do this: Remove the expectations from 'efl' TestExpectations and (when it makes sense) add them into 'efl-wk1' TestExpectations.
Attachments
Patch
(13.93 KB, patch)
2012-10-09 03:28 PDT
,
Jussi Kukkonen (jku)
no flags
Details
Formatted Diff
Diff
Patch
(14.11 KB, patch)
2012-10-09 03:41 PDT
,
Jussi Kukkonen (jku)
no flags
Details
Formatted Diff
Diff
Patch
(14.14 KB, patch)
2012-10-09 04:10 PDT
,
Jussi Kukkonen (jku)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1
2012-10-09 03:28:25 PDT
Created
attachment 167721
[details]
Patch
Jussi Kukkonen (jku)
Comment 2
2012-10-09 03:41:18 PDT
Created
attachment 167725
[details]
Patch
WebKit Review Bot
Comment 3
2012-10-09 03:59:14 PDT
Comment on
attachment 167725
[details]
Patch Rejecting
attachment 167725
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/14207858
Jussi Kukkonen (jku)
Comment 4
2012-10-09 04:10:58 PDT
Created
attachment 167729
[details]
Patch
WebKit Review Bot
Comment 5
2012-10-09 04:55:00 PDT
Comment on
attachment 167729
[details]
Patch Clearing flags on attachment: 167729 Committed
r130751
: <
http://trac.webkit.org/changeset/130751
>
WebKit Review Bot
Comment 6
2012-10-09 04:55:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug