Bug 98731 - [GTK] Test /webkit2/WebKitWebView/history-cache asserts in debug bot
Summary: [GTK] Test /webkit2/WebKitWebView/history-cache asserts in debug bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-10-09 02:04 PDT by Carlos Garcia Campos
Modified: 2012-10-10 04:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2012-10-09 02:09 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-10-09 02:04:56 PDT
I think the problem is in the test itself that uses the SingleResourceLoadTest to load a multiresource document.
Comment 1 Carlos Garcia Campos 2012-10-09 02:09:06 PDT
Created attachment 167713 [details]
Patch

I'm unable to reproduce the assertion, so I'm not sure the patch will fix it.
Comment 2 Carlos Garcia Campos 2012-10-09 02:10:12 PDT
Btw, the assertion is this one:

  /webkit2/WebKitWebView/history-cache:                                ASSERTION FAILED: m_loadState == LoadStateCommitted

../../Source/WebKit2/UIProcess/WebFrameProxy.cpp(176) : void WebKit::WebFrameProxy::didFinishLoad()
Comment 3 WebKit Review Bot 2012-10-09 02:11:20 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2012-10-10 04:16:18 PDT
Committed r130886: <http://trac.webkit.org/changeset/130886>