This is just a refactoring job to rename RegisterFile to JSStack in preparation for topCallFrame changes. The are no semantic changes in this change set.
Created attachment 167685 [details] Fix: renamed RegisterFile to JSStack, and removed the prototype of the previously deleted Interpreter::privateExecute().
Attachment 167685 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/interpreter/JSStack.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/JSLock.cpp:146: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/runtime/JSLock.cpp:149: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 69 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Source/JavaScriptCore/interpreter/JSStack.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4] This indentation was there before. To minimize the diff, I'm leaving them as is. > Source/JavaScriptCore/runtime/JSLock.cpp:146: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] > Source/JavaScriptCore/runtime/JSLock.cpp:149: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] > Total errors found: 3 in 69 files These spaces were there before my change, and they make the comment more readable. I'm leaving them as is.
Ready for review? (I'm tempted to rubber stamp. I concur with the renaming.)
Comment on attachment 167685 [details] Fix: renamed RegisterFile to JSStack, and removed the prototype of the previously deleted Interpreter::privateExecute(). Was waiting for some of the ews bots to confirm that I didn't bork their builds. We're ready for the review now.
R=me.
Landed in <http://trac.webkit.org/changeset/130726>.
Makes me think that "CallFrame" should be renamed to "StackFrame" or "JSStackFrame".
(In reply to comment #8) > Makes me think that "CallFrame" should be renamed to "StackFrame" or "JSStackFrame". I will revisit that later.